Allow use of the chrome trace categories string from the tracing ui internals.

Allow use of the chrome trace categories string from the tracing ui internals.

BUG=96123
TEST=manual & run pyauto tracing smoke tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151998

[jbates, 2012-08-09 00:44:06]

https://chromiumcodereview.appspot.com/10855062/diff/1/content/browser/trace_...
File content/browser/trace_controller_impl.cc (right):

https://chromiumcodereview.appspot.com/10855062/diff/1/content/browser/trace_...
content/browser/trace_controller_impl.cc:112: bool success =
BeginTracing(subscriber, "-test_*") &&
I think the category string should just be "*".

[Russ Harmon, 2012-08-09 00:45:32]

https://chromiumcodereview.appspot.com/10855062/diff/1/content/browser/trace_...
File content/browser/trace_controller_impl.cc (right):

https://chromiumcodereview.appspot.com/10855062/diff/1/content/browser/trace_...
content/browser/trace_controller_impl.cc:112: bool success =
BeginTracing(subscriber, "-test_*") &&
On 2012/08/09 00:44:06, jbates wrote:
> I think the category string should just be "*".
Ok. I was preserving the existing behavior since I wasn't sure. I'll change it.

[jbates, 2012-08-09 00:47:13]

Cool, looking forward to this going in! LGTM once the category is changed.

[Russ Harmon, 2012-08-13 18:40:39]

Do note that this is rev-locked with https://codereview.appspot.com/6453101/

[sky, 2012-08-14 22:38:03]

LGTM

https://chromiumcodereview.appspot.com/10855062/diff/1005/chrome/browser/ui/w...
File chrome/browser/ui/webui/tracing_ui.cc (right):

https://chromiumcodereview.appspot.com/10855062/diff/1005/chrome/browser/ui/w...
chrome/browser/ui/webui/tracing_ui.cc:434: DCHECK(args->GetSize() == 2);
DCHECK_EQ

[Russ Harmon, 2012-08-14 22:38:04]

arv, sky, rdsmith: can you review when you get a chance?

[Randy Smith (Not in Mondays), 2012-08-15 17:22:23]

On 2012/08/14 22:38:04, Russ Harmon wrote:
> arv, sky, rdsmith: can you review when you get a chance?

Forgive me for the ping, but what do you want me to review?  There's no code in
this CL that I'm consciously aware of knowing, but maybe I've forgotten that I
knew some code :-}.

[Russ Harmon, 2012-08-16 00:43:30]

On 2012/08/15 17:22:23, rdsmith wrote:
> On 2012/08/14 22:38:04, Russ Harmon wrote:
> > arv, sky, rdsmith: can you review when you get a chance?
> 
> Forgive me for the ping, but what do you want me to review?  There's no code
in
> this CL that I'm consciously aware of knowing, but maybe I've forgotten that I
> knew some code :-}.

rdsmith: Sorry if you're not the correct person for this, but you're the only
person listed in content/public/browser/OWNERS

[Randy Smith (Not in Mondays), 2012-08-16 13:30:18]

On 2012/08/16 00:43:30, Russ Harmon wrote:
> On 2012/08/15 17:22:23, rdsmith wrote:
> > On 2012/08/14 22:38:04, Russ Harmon wrote:
> > > arv, sky, rdsmith: can you review when you get a chance?
> > 
> > Forgive me for the ping, but what do you want me to review?  There's no code
> in
> > this CL that I'm consciously aware of knowing, but maybe I've forgotten that
I
> > knew some code :-}.
> 
> rdsmith: Sorry if you're not the correct person for this, but you're the only
> person listed in content/public/browser/OWNERS

Ah!  That's only for download related code (content/public/browser/download*);
I'm not authorized to stamp anything else.  You need an owner from
content/public.  I think you want Joi; I've added him.

I should update the comment.

[Jói, 2012-08-16 13:47:09]

LGTM for content/public, but you'll need one of content/OWNERS to approve the
content/browser changes.

[Russ Harmon, 2012-08-16 18:50:35]

On 2012/08/16 13:47:09, Jói wrote:
> LGTM for content/public, but you'll need one of content/OWNERS to approve the
> content/browser changes.

sky@ is listed in content/browser/OWNERS. Is that not sufficient?

[arv (Not doing code reviews), 2012-08-16 18:55:02]

LGTM

[Jói, 2012-08-16 19:09:15]

> sky@ is listed in content/browser/OWNERS. Is that not sufficient?

That's sufficient, sorry for the confusion.

[commit-bot: I haz the power, 2012-08-16 20:59:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eatnumber@chromium.org/10855062/11001

[commit-bot: I haz the power, 2012-08-17 00:13:40]

Change committed as 151998