Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 10855061: Properly notify the handle verifier when a handle is passed around. This CL fixes issues introduced… (Closed)

Created:
8 years, 4 months ago by alexeypa (please no reviews)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Properly notify the handle verifier when a handle is passed around. This CL fixes issues introduced by r150508. BUG=134694 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150825

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M base/win/scoped_handle.h View 1 3 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
alexeypa (please no reviews)
Your intuition was right. https://chromiumcodereview.appspot.com/10828160/ broke the handle verifier logic. Please take a look at ...
8 years, 4 months ago (2012-08-08 23:41:06 UTC) #1
jar (doing other things)
with only possible (not definite) nit.... LGTM https://chromiumcodereview.appspot.com/10855061/diff/1/base/win/scoped_handle.h File base/win/scoped_handle.h (right): https://chromiumcodereview.appspot.com/10855061/diff/1/base/win/scoped_handle.h#newcode66 base/win/scoped_handle.h:66: if (this ...
8 years, 4 months ago (2012-08-09 00:00:49 UTC) #2
alexeypa (please no reviews)
https://chromiumcodereview.appspot.com/10855061/diff/1/base/win/scoped_handle.h File base/win/scoped_handle.h (right): https://chromiumcodereview.appspot.com/10855061/diff/1/base/win/scoped_handle.h#newcode66 base/win/scoped_handle.h:66: if (this != static_cast<GenericScopedHandle*>(&other)) { On 2012/08/09 00:00:49, jar ...
8 years, 4 months ago (2012-08-09 15:39:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10855061/5001
8 years, 4 months ago (2012-08-09 15:39:13 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 17:15:14 UTC) #5
Change committed as 150825

Powered by Google App Engine
This is Rietveld 408576698