Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 10855060: Make java_aidl targets export include directories (Closed)

Created:
8 years, 4 months ago by cjhopman
Modified:
8 years, 4 months ago
Reviewers:
Yaron, nilesh, brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@ant
Visibility:
Public.

Description

Make java_aidl targets export include directories Native code generation rules typically add their output directory to their dependent's 'include_dirs'. This change makes targets that include java_aidl.gypi do a similar thing for other java*.gypi targets. Make java.gypi pass this variable to ant and content.xml use the variable rather than hardcoding the directory. Also, move the aidl output folder into <(SHARED_INTERMEDIATE_DIR) as it should be. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151315

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M build/java.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M build/java_aidl.gypi View 3 chunks +10 lines, -2 lines 0 comments Download
M content/content.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/android/java/content.xml View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
cjhopman
8 years, 4 months ago (2012-08-09 00:17:52 UTC) #1
Yaron
lgtm
8 years, 4 months ago (2012-08-09 01:13:37 UTC) #2
cjhopman
8 years, 4 months ago (2012-08-09 16:11:39 UTC) #3
nilesh
On 2012/08/09 16:11:39, cjhopman wrote: LGTM
8 years, 4 months ago (2012-08-09 16:56:58 UTC) #4
cjhopman
brettw: content/
8 years, 4 months ago (2012-08-09 19:13:22 UTC) #5
brettw
Owners rubberstamp, but as usual I have no idea what's going on.
8 years, 4 months ago (2012-08-09 19:50:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/10855060/2001
8 years, 4 months ago (2012-08-09 22:32:51 UTC) #7
commit-bot: I haz the power
Presubmit check for 10855060-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-09 22:32:54 UTC) #8
cjhopman
On 2012/08/09 22:32:54, I haz the power (commit-bot) wrote: > Presubmit check for 10855060-2001 failed ...
8 years, 4 months ago (2012-08-09 22:39:30 UTC) #9
brettw
lgtm
8 years, 4 months ago (2012-08-13 17:09:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/10855060/2001
8 years, 4 months ago (2012-08-13 17:25:02 UTC) #11
commit-bot: I haz the power
8 years, 4 months ago (2012-08-13 18:35:51 UTC) #12
Change committed as 151315

Powered by Google App Engine
This is Rietveld 408576698