Issue 10855059: Move Ash wallpapers into a separate grd/pak file to avoid duplication

Issue 10855059: Move Ash wallpapers into a separate grd/pak file to avoid duplication (Closed)

Created:
8 years, 4 months ago by benrg

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google), Emmanuel Saint-loubert-Bié

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org, Ian Vollick, grt+watch_chromium.org, amit, jonathan.backer, jam, piman+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, pam+watch_chromium.org, oshima+watch_chromium.org, darin-cc_chromium.org, robertshield, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move Ash wallpapers into a separate grd/pak file to avoid duplication BUG=141467 TEST=Local Linux build, try changing wallpaper TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150745

Patch Set 1 #

Patch Set 2 : Fix dependencies #

Patch Set 3 : Fix dependencies again #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -103 lines)			Patch
M	ash/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/ash.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/desktop_background/desktop_background_resources.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_repack_chrome.gypi	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/chrome_resources.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/tools/check_grd_for_unused_strings.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gritsettings/resource_ids	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	ui/resources/ui_resources.grd	View		1 chunk	+0 lines, -101 lines	0 comments	Download
A	ui/resources/ui_resources_wallpapers.grd	View	1	1 chunk	+111 lines, -0 lines	0 comments	Download
M	ui/ui_resources.gypi	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emmanuel Saint-loubert-Bié

LGTM. I would like to see the assets reorganized as per ben@ suggestion, but not ...

8 years, 4 months ago (2012-08-09 00:17:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benrg@chromium.org/10855059/9001

8 years, 4 months ago (2012-08-09 03:58:53 UTC) #4

Change committed as 150745

Expand Messages | Collapse Messages