Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Side by Side Diff: vm/object.cc

Issue 10855052: Don't call IdentifierPrettyName with signature classes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/bigint_operations.h" 10 #include "vm/bigint_operations.h"
(...skipping 1197 matching lines...) Expand 10 before | Expand all | Expand 10 after
1208 case kUint64Array: 1208 case kUint64Array:
1209 case kExternalUint64Array: 1209 case kExternalUint64Array:
1210 return Symbols::New("Uint64List"); 1210 return Symbols::New("Uint64List");
1211 case kFloat32Array: 1211 case kFloat32Array:
1212 case kExternalFloat32Array: 1212 case kExternalFloat32Array:
1213 return Symbols::New("Float32List"); 1213 return Symbols::New("Float32List");
1214 case kFloat64Array: 1214 case kFloat64Array:
1215 case kExternalFloat64Array: 1215 case kExternalFloat64Array:
1216 return Symbols::New("Float64List"); 1216 return Symbols::New("Float64List");
1217 default: 1217 default:
1218 const String& name = String::Handle(Name()); 1218 if (!IsSignatureClass()) {
1219 return IdentifierPrettyName(name); 1219 const String& name = String::Handle(Name());
1220 return IdentifierPrettyName(name);
1221 } else {
1222 return Name();
1223 }
1220 } 1224 }
1221 UNREACHABLE(); 1225 UNREACHABLE();
1222 } 1226 }
1223 1227
1224 1228
1225 RawType* Class::SignatureType() const { 1229 RawType* Class::SignatureType() const {
1226 ASSERT(IsSignatureClass()); 1230 ASSERT(IsSignatureClass());
1227 const Function& function = Function::Handle(signature_function()); 1231 const Function& function = Function::Handle(signature_function());
1228 ASSERT(!function.IsNull()); 1232 ASSERT(!function.IsNull());
1229 if (function.signature_class() != raw()) { 1233 if (function.signature_class() != raw()) {
(...skipping 9957 matching lines...) Expand 10 before | Expand all | Expand 10 after
11187 const char* JSRegExp::ToCString() const { 11191 const char* JSRegExp::ToCString() const {
11188 const String& str = String::Handle(pattern()); 11192 const String& str = String::Handle(pattern());
11189 const char* format = "JSRegExp: pattern=%s flags=%s"; 11193 const char* format = "JSRegExp: pattern=%s flags=%s";
11190 intptr_t len = OS::SNPrint(NULL, 0, format, str.ToCString(), Flags()); 11194 intptr_t len = OS::SNPrint(NULL, 0, format, str.ToCString(), Flags());
11191 char* chars = Isolate::Current()->current_zone()->Alloc<char>(len + 1); 11195 char* chars = Isolate::Current()->current_zone()->Alloc<char>(len + 1);
11192 OS::SNPrint(chars, (len + 1), format, str.ToCString(), Flags()); 11196 OS::SNPrint(chars, (len + 1), format, str.ToCString(), Flags());
11193 return chars; 11197 return chars;
11194 } 11198 }
11195 11199
11196 } // namespace dart 11200 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698