Issue 10855048: Update protobuf.gyp for iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10855048: Update protobuf.gyp for iOS. (Closed)

Created:
8 years, 4 months ago by qsr

Modified:
8 years, 4 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Update protobuf.gyp for iOS. protoc must be build for the Mac platform and not for iOS. mac_build.gypi is used to allow this. TEST=None BUG=None R=stuartmorgan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150778

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -66 lines)			Patch
	M	third_party/protobuf/protobuf.gyp	View		1 chunk	+106 lines, -66 lines	0 comments	Download

Total messages: 6 (0 generated)

stuartmorgan

LGTM, just CL description nits: s/mac/Mac/ s/the iphone platform/iOS/

8 years, 4 months ago (2012-08-08 12:36:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/10855048/1

8 years, 4 months ago (2012-08-08 12:41:02 UTC) #3

commit-bot: I haz the power

Try job failure for 10855048-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...

8 years, 4 months ago (2012-08-08 14:02:31 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/10855048/1

8 years, 4 months ago (2012-08-09 09:16:05 UTC) #5

Change committed as 150778