Issue 10855039: Cleanup: Remove FileSystemFileUtil::{Directory,Path}Exists

Issue 10855039: Cleanup: Remove FileSystemFileUtil::{Directory,Path}Exists (Closed)

Created:
8 years, 4 months ago by tzik

Modified:
8 years, 4 months ago

Reviewers:
kinuko

CC:
chromium-reviews, feature-media-reviews_chromium.org, kinuko+watch, darin-cc_chromium.org, nhiroki

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove FileSystemFileUtil::{Directory,Path}Exists They were used in file_util_helper.cc and by tests only, and is not needed to exist separate implementation per FileUtil. Can I remove it like this? BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151234

Patch Set 1 #

Patch Set 2 : test fix #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -241 lines)			Patch
M	webkit/fileapi/file_system_file_util.h	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	webkit/fileapi/file_util_helper.h	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	webkit/fileapi/file_util_helper.cc	View	1	6 chunks	+35 lines, -8 lines	0 comments	Download
M	webkit/fileapi/isolated_file_util.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	webkit/fileapi/isolated_file_util.cc	View		2 chunks	+1 line, -21 lines	0 comments	Download
M	webkit/fileapi/local_file_system_operation_unittest.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	webkit/fileapi/local_file_system_quota_unittest.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	webkit/fileapi/local_file_util.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	webkit/fileapi/local_file_util.cc	View		1 chunk	+0 lines, -18 lines	0 comments	Download
M	webkit/fileapi/media/device_media_file_util.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	webkit/fileapi/media/device_media_file_util.cc	View		1 chunk	+0 lines, -20 lines	0 comments	Download
M	webkit/fileapi/media/native_media_file_util.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	webkit/fileapi/media/native_media_file_util.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	webkit/fileapi/obfuscated_file_util.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	webkit/fileapi/obfuscated_file_util.cc	View		1 chunk	+0 lines, -39 lines	0 comments	Download
M	webkit/fileapi/obfuscated_file_util_unittest.cc	View	1	11 chunks	+43 lines, -50 lines	0 comments	Download
M	webkit/fileapi/sandbox_mount_point_provider_unittest.cc	View		3 chunks	+26 lines, -30 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kinuko

lgtm I found that FSO::DirectoryExists doesn't actually call FU::DirectoryExists just yesterday and was surprised.

8 years, 4 months ago (2012-08-10 08:29:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/10855039/2002

8 years, 4 months ago (2012-08-13 04:54:00 UTC) #2

Change committed as 151234

Expand Messages | Collapse Messages