content/browser/renderer_host/render_widget_host_view_mac_unittest.mm - Issue 10855036: Adding selection text direction to SelectionBoundsChanged.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

Issue 10855036: Adding selection text direction to SelectionBoundsChanged. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Synced Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | content/browser/renderer_host/render_widget_host_view_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

index 5ad0070675a68487f3fff385c1eafe04aa6dc7d0..59ac4430764cfd0531c4c67da9ce675fd10bda52 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

@@ -251,7 +251,7 @@ TEST_F(RenderWidgetHostViewMacTest, Fullscreen) {

EXPECT_TRUE(rwhv_mac_->pepper_fullscreen_window());

}

-TEST_F(RenderWidgetHostViewMacTest, GetFirstRectForCharaacterRangeCaretCase) {

+TEST_F(RenderWidgetHostViewMacTest, GetFirstRectForCharacterRangeCaretCase) {

const string16 kDummyString = UTF8ToUTF16("hogehoge");

const size_t kDummyOffset = 0;

@@ -261,7 +261,9 @@ TEST_F(RenderWidgetHostViewMacTest, GetFirstRectForCharaacterRangeCaretCase) {

NSRect rect;

NSRange actual_range;

rwhv_mac_->SelectionChanged(kDummyString, kDummyOffset, caret_range);

- rwhv_mac_->SelectionBoundsChanged(caret_rect, caret_rect);

+ rwhv_mac_->SelectionBoundsChanged(

+ caret_rect, WebKit::WebTextDirectionLeftToRight,

+ caret_rect, WebKit::WebTextDirectionLeftToRight);

EXPECT_TRUE(rwhv_mac_->GetCachedFirstRectForCharacterRange(

caret_range.ToNSRange(),

&rect,

@@ -286,7 +288,9 @@ TEST_F(RenderWidgetHostViewMacTest, GetFirstRectForCharaacterRangeCaretCase) {

caret_rect = gfx::Rect(20, 11, 0, 10);

caret_range = ui::Range(1, 1);

rwhv_mac_->SelectionChanged(kDummyString, kDummyOffset, caret_range);

- rwhv_mac_->SelectionBoundsChanged(caret_rect, caret_rect);

+ rwhv_mac_->SelectionBoundsChanged(

+ caret_rect, WebKit::WebTextDirectionLeftToRight,

+ caret_rect, WebKit::WebTextDirectionLeftToRight);

EXPECT_TRUE(rwhv_mac_->GetCachedFirstRectForCharacterRange(

caret_range.ToNSRange(),

&rect,

@@ -310,7 +314,9 @@ TEST_F(RenderWidgetHostViewMacTest, GetFirstRectForCharaacterRangeCaretCase) {

// No caret.

caret_range = ui::Range(1, 2);

rwhv_mac_->SelectionChanged(kDummyString, kDummyOffset, caret_range);

- rwhv_mac_->SelectionBoundsChanged(caret_rect, gfx::Rect(30, 11, 0, 10));

+ rwhv_mac_->SelectionBoundsChanged(

+ caret_rect, WebKit::WebTextDirectionLeftToRight,

+ gfx::Rect(30, 11, 0, 10), WebKit::WebTextDirectionLeftToRight);

EXPECT_FALSE(rwhv_mac_->GetCachedFirstRectForCharacterRange(

ui::Range(0, 0).ToNSRange(),

&rect,