Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10855036: Adding selection text direction to SelectionBoundsChanged. (Closed)

Created:
8 years, 4 months ago by Jay Civelli
Modified:
8 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Adding selection text direction to SelectionBoundsChanged. Adding the selection text direction to the notification that the selection bounds have changed. This is used with touch UI. BUG=138944 TEST=All tests should pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151137

Patch Set 1 #

Patch Set 2 : Fixing compilation errors. #

Patch Set 3 : Synced #

Patch Set 4 : Synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -27 lines) Patch
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 4 chunks +10 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M content/common/view_messages.h View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 2 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Jay Civelli
8 years, 4 months ago (2012-08-07 23:10:52 UTC) #1
Avi (use Gerrit)
lgtm
8 years, 4 months ago (2012-08-07 23:28:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/10855036/9001
8 years, 4 months ago (2012-08-08 17:10:20 UTC) #3
commit-bot: I haz the power
Try job failure for 10855036-9001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-08 18:21:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/10855036/9001
8 years, 4 months ago (2012-08-08 18:46:05 UTC) #5
commit-bot: I haz the power
Try job failure for 10855036-9001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-08 20:16:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/10855036/21
8 years, 4 months ago (2012-08-10 19:50:26 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-10 22:18:31 UTC) #8 
Change committed as 151137

Powered by Google App Engine
This is Rietveld 408576698