Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 10855031: Add UI string for the permissions drop downs of the Website Settings UI that are easy to localize. (Closed)

Created:
8 years, 4 months ago by markusheintz_
Modified:
8 years, 4 months ago
CC:
chromium-reviews, tfarina, Patrick Dubroy
Visibility:
Public.

Description

Concatenated strings are hard to localize. Menu items and button texts should be provided as a complete strings instead of a concatenation of two strings. Add UI strings for the permissions drop downs of the Website Settings UI that are easy to localize. BUG=113688 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151019

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Patch Set 4 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -25 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +15 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/website_settings_popup_gtk.cc View 1 2 2 chunks +21 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permission_selector_view.cc View 1 chunk +21 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
markusheintz_
Please review this CL. Thanks. @Elliot: Please review the GTK parts. @Ben: Please review the ...
8 years, 4 months ago (2012-08-09 00:34:31 UTC) #1
markusheintz_
On 2012/08/09 00:34:31, markusheintz_ wrote: > Please review this CL. Thanks. > > @Elliot: Please ...
8 years, 4 months ago (2012-08-09 12:34:59 UTC) #2
Ben Goodger (Google)
views/grd lgtm
8 years, 4 months ago (2012-08-09 15:45:56 UTC) #3
Elliot Glaysher
gtk lgtm
8 years, 4 months ago (2012-08-09 16:42:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10855031/10001
8 years, 4 months ago (2012-08-09 19:11:23 UTC) #5
commit-bot: I haz the power
Try job failure for 10855031-10001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-09 20:33:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10855031/10001
8 years, 4 months ago (2012-08-10 09:40:19 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-10 12:49:42 UTC) #8
Change committed as 151019

Powered by Google App Engine
This is Rietveld 408576698