Remove the effects of --disable-restore-session-state.

Remove the effects of --disable-restore-session-state.

The "Better Session Restore" features have been on by default for quite a while,
and there are no known problems.

This CL removes the effects of --disable-restore-session-state but keeps the
flag and the about:flags flag in place. New experimental features are ready to be
enabled by default, and this flag will be used again to disable them.

BUG=116947
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150541

[marja, 2012-08-07 12:42:36]

Hi erikwright, sail, sky,

sky, sail: could you review the following parts:
sail:
chrome/browser/profiles/*
sky:
chrome/browser/sessions/*
chrome/browser/lifetime/*

erikwright: Would you also like me to remove
CookieMonster::SetPersistSessionCookies, or would you like to have this
configuration option for other uses (e.g., other platforms)? (I can do it in a
separate CL.)

[erikwright (departed), 2012-08-07 12:46:32]

I believe jgreenwald (cc'd) intends to use SetPersistSessionCookies.

Is that correct, Jesse?

-e

[sail, 2012-08-07 17:09:40]

profiles/* LGTM!

[Jesse Greenwald, 2012-08-07 17:45:47]

On 2012/08/07 12:46:32, erikwright wrote:
> I believe jgreenwald (cc'd) intends to use SetPersistSessionCookies.
> 
> Is that correct, Jesse?
> 
> -e

Yup, this looks good to me.  Thanks for looping me in.

[sky, 2012-08-07 20:25:13]

http://codereview.chromium.org/10855022/diff/1/chrome/browser/sessions/base_s...
File chrome/browser/sessions/base_session_service.cc (left):

http://codereview.chromium.org/10855022/diff/1/chrome/browser/sessions/base_s...
chrome/browser/sessions/base_session_service.cc:85:
!command_line->HasSwitch(switches::kDisableRestoreSessionState);
Can we remove the flag too?

[sky, 2012-08-07 20:28:37]

LGTM

[commit-bot: I haz the power, 2012-08-07 20:30:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/10855022/1

[commit-bot: I haz the power, 2012-08-07 21:04:52]

Try job failure for 10855022-1 (retry) on linux_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[marja, 2012-08-08 09:37:36]

FYI, updated tests too, and removed a test which was testing functionality
(removing post data) which is no longer there.

[commit-bot: I haz the power, 2012-08-08 09:37:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/10855022/8002

[commit-bot: I haz the power, 2012-08-08 12:21:48]

Change committed as 150541