Chromium Code Reviews| Index: dart/lib/compiler/implementation/ssa/builder.dart |
| diff --git a/dart/lib/compiler/implementation/ssa/builder.dart b/dart/lib/compiler/implementation/ssa/builder.dart |
| index 6f72e0441d5bddb8822d44995fcd7cfd0299d721..7aba3c44accefc88a226b09e8344a2dba8bc4830 100644 |
| --- a/dart/lib/compiler/implementation/ssa/builder.dart |
| +++ b/dart/lib/compiler/implementation/ssa/builder.dart |
| @@ -3299,8 +3299,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor { |
| if (element === builder.compiler.boolClass) return HType.BOOLEAN; |
|
kasperl
2012/08/08 12:36:47
I'm a bit worried about how we deal with null here
ahe
2012/08/08 12:40:04
Right now, I use the intClass to mean the concrete
|
| if (element === builder.compiler.doubleClass) return HType.DOUBLE; |
| if (element === builder.compiler.intClass) return HType.INTEGER; |
| - // TODO(ahe): How to map listClass to HType? |
| - if (element === builder.compiler.listClass) return HType.UNKNOWN; |
| + if (element === builder.compiler.listClass) return HType.READABLE_ARRAY; |
|
ngeoffray
2012/08/16 12:55:40
Why?
ahe
2012/08/16 17:15:19
What else would you use?
ngeoffray
2012/08/17 07:59:28
HBoundedPotentialPrimitiveArray. A user-defined cl
ahe
2012/08/21 15:05:38
It will always be a JS array. That is what concret
|
| if (element === builder.compiler.nullClass) return HType.NULL; |
| if (element === builder.compiler.stringClass) return HType.STRING; |
| return HType.UNKNOWN; |