Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1407)

Issue 10855017: Add missing fields in Drive V2 API parser. (Closed)

Created:
8 years, 4 months ago by kochi
Modified:
8 years, 4 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, satorux1, Daniel Erat
Visibility:
Public.

Description

Add missing fields in Drive V2 API parser. These added fields are necessary to work with our file system implementation. BUG=chromium:127728 TEST=unit_tests --gtest_filter="DriveAPI*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150291

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix for comments #

Total comments: 6

Patch Set 3 : Reorder fields, add missed "deleted" field parsing in ChangeResource. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -38 lines) Patch
M chrome/browser/chromeos/gdata/drive_api_parser.h View 1 2 7 chunks +45 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_api_parser.cc View 1 2 8 chunks +66 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_api_parser_unittest.cc View 5 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
kochi
Ryo, Could you review this CL? Thanks,
8 years, 4 months ago (2012-08-07 04:05:30 UTC) #1
hashimoto
https://chromiumcodereview.appspot.com/10855017/diff/1/chrome/browser/chromeos/gdata/drive_api_parser.cc File chrome/browser/chromeos/gdata/drive_api_parser.cc (right): https://chromiumcodereview.appspot.com/10855017/diff/1/chrome/browser/chromeos/gdata/drive_api_parser.cc#newcode88 chrome/browser/chromeos/gdata/drive_api_parser.cc:88: const char kAlternateLink[] = "alternateLink"; Is there a policy ...
8 years, 4 months ago (2012-08-07 04:19:02 UTC) #2
kochi
Thanks for your quick review! https://chromiumcodereview.appspot.com/10855017/diff/1/chrome/browser/chromeos/gdata/drive_api_parser.cc File chrome/browser/chromeos/gdata/drive_api_parser.cc (right): https://chromiumcodereview.appspot.com/10855017/diff/1/chrome/browser/chromeos/gdata/drive_api_parser.cc#newcode88 chrome/browser/chromeos/gdata/drive_api_parser.cc:88: const char kAlternateLink[] = ...
8 years, 4 months ago (2012-08-07 05:24:37 UTC) #3
hashimoto
https://chromiumcodereview.appspot.com/10855017/diff/8001/chrome/browser/chromeos/gdata/drive_api_parser.cc File chrome/browser/chromeos/gdata/drive_api_parser.cc (right): https://chromiumcodereview.appspot.com/10855017/diff/8001/chrome/browser/chromeos/gdata/drive_api_parser.cc#newcode382 chrome/browser/chromeos/gdata/drive_api_parser.cc:382: converter->RegisterCustomField<base::Time>( Could you order these too? https://chromiumcodereview.appspot.com/10855017/diff/8001/chrome/browser/chromeos/gdata/drive_api_parser.h File chrome/browser/chromeos/gdata/drive_api_parser.h ...
8 years, 4 months ago (2012-08-07 05:55:04 UTC) #4
kochi
https://chromiumcodereview.appspot.com/10855017/diff/8001/chrome/browser/chromeos/gdata/drive_api_parser.cc File chrome/browser/chromeos/gdata/drive_api_parser.cc (right): https://chromiumcodereview.appspot.com/10855017/diff/8001/chrome/browser/chromeos/gdata/drive_api_parser.cc#newcode382 chrome/browser/chromeos/gdata/drive_api_parser.cc:382: converter->RegisterCustomField<base::Time>( On 2012/08/07 05:55:04, hashimoto wrote: > Could you ...
8 years, 4 months ago (2012-08-07 06:30:37 UTC) #5
hashimoto
8 years, 4 months ago (2012-08-07 06:38:58 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698