Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: chrome/renderer/resources/extensions/schema_generated_bindings.js

Issue 10855015: Add documentation for filtered events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase again Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/schema_generated_bindings.js
diff --git a/chrome/renderer/resources/extensions/schema_generated_bindings.js b/chrome/renderer/resources/extensions/schema_generated_bindings.js
index b4ab3d6e39f3e19a4cd2514453bca60992c3cbff..ecf46f31011c39925034a6d11c003ba5c902d86b 100644
--- a/chrome/renderer/resources/extensions/schema_generated_bindings.js
+++ b/chrome/renderer/resources/extensions/schema_generated_bindings.js
@@ -342,15 +342,20 @@
var eventName = apiDef.namespace + "." + eventDef.name;
var customEvent = customEvents[apiDef.namespace];
+ var options = eventDef.options || {};
+
+ if (eventDef.filters && eventDef.filters.length > 0)
+ options.supportsFilters = true;
+
if (customEvent) {
mod[eventDef.name] = new customEvent(
eventName, eventDef.parameters, eventDef.extraParameters,
- eventDef.options);
+ options);
} else if (eventDef.anonymous) {
mod[eventDef.name] = new chrome.Event();
} else {
mod[eventDef.name] = new chrome.Event(
- eventName, eventDef.parameters, eventDef.options);
+ eventName, eventDef.parameters, options);
}
});
}
« no previous file with comments | « chrome/renderer/resources/extensions/event.js ('k') | chrome/renderer/resources/extensions/web_request_custom_bindings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698