Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 10855015: Add documentation for filtered events. (Closed)

Created:
8 years, 4 months ago by koz (OOO until 15th September)
Modified:
8 years, 4 months ago
Reviewers:
Aaron Boodman, aa
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : work #

Patch Set 3 : rebase #

Patch Set 4 : regenerate #

Patch Set 5 : remove integration_test.py #

Patch Set 6 : fix tests #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Patch Set 9 : rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+651 lines, -55 lines) Patch
M chrome/common/extensions/api/web_navigation.json View 1 9 chunks +64 lines, -45 lines 0 comments Download
M chrome/common/extensions/docs/apps/events.html View 1 2 3 2 chunks +34 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/alarms.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/bookmarks.html View 1 2 3 7 chunks +7 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/browserAction.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/contextMenus.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/cookies.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/debugger.html View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/devtools.inspectedWindow.html View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/devtools.network.html View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/devtools.panels.html View 1 2 3 7 chunks +7 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/downloads.html View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/events.html View 1 2 3 2 chunks +34 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/experimental.bluetooth.html View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/experimental.commands.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/experimental.devtools.audits.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/experimental.devtools.console.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/experimental.offscreenTabs.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/experimental.processes.html View 1 2 3 5 chunks +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/experimental.speechInput.html View 1 2 3 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/experimental.usb.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/extension.html View 1 2 3 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/fileBrowserHandler.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/fontSettings.html View 1 2 3 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/history.html View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/idle.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/input.ime.html View 1 2 3 8 chunks +8 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/management.html View 1 2 3 4 5 6 7 8 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/omnibox.html View 1 2 3 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/pageAction.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/permissions.html View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/proxy.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/runtime.html View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/scriptBadge.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/storage.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/tabs.html View 1 2 3 8 chunks +8 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/ttsEngine.html View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/types.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/webNavigation.html View 1 2 9 chunks +289 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/webRequest.html View 1 2 3 9 chunks +9 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/extensions/windows.html View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/intros/events.html View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/static/events.html View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/template/api_template.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/event.js View 1 2 3 4 5 3 chunks +20 lines, -5 lines 0 comments Download
M chrome/renderer/resources/extensions/schema_generated_bindings.js View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/web_request_custom_bindings.js View 1 2 3 4 5 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
koz (OOO until 15th September)
8 years, 4 months ago (2012-08-07 07:17:33 UTC) #1
Aaron Boodman
LGTM
8 years, 4 months ago (2012-08-13 19:10:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10855015/5001
8 years, 4 months ago (2012-08-14 00:09:21 UTC) #3
commit-bot: I haz the power
Presubmit check for 10855015-5001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-14 00:10:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10855015/8001
8 years, 4 months ago (2012-08-14 02:07:25 UTC) #5
commit-bot: I haz the power
Presubmit check for 10855015-8001 failed and returned exit status 1. /b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/integration_test.py: Has executable bit but ...
8 years, 4 months ago (2012-08-14 02:07:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10855015/5003
8 years, 4 months ago (2012-08-14 02:18:33 UTC) #7
commit-bot: I haz the power
Presubmit check for 10855015-5003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-14 02:18:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10855015/7008
8 years, 4 months ago (2012-08-14 06:11:42 UTC) #9
commit-bot: I haz the power
Presubmit check for 10855015-7008 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-14 06:11:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10855015/7008
8 years, 4 months ago (2012-08-15 00:54:07 UTC) #11
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/docs/extensions/experimental.app.html: While running patch -p1 --forward --force; patching file chrome/common/extensions/docs/extensions/experimental.app.html ...
8 years, 4 months ago (2012-08-15 00:54:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10855015/1005
8 years, 4 months ago (2012-08-15 01:25:05 UTC) #13
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/docs/extensions/experimental.app.html: While running patch -p1 --forward --force; patching file chrome/common/extensions/docs/extensions/experimental.app.html ...
8 years, 4 months ago (2012-08-15 01:25:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10855015/11050
8 years, 4 months ago (2012-08-15 03:50:18 UTC) #15
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/docs/extensions/experimental.app.html: While running patch -p1 --forward --force; patching file chrome/common/extensions/docs/extensions/experimental.app.html ...
8 years, 4 months ago (2012-08-15 03:50:27 UTC) #16
Aaron Boodman
It's making me sad watchign you fight with this. I'm going to land it for ...
8 years, 4 months ago (2012-08-16 00:29:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10855015/9097
8 years, 4 months ago (2012-08-17 00:09:43 UTC) #18
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 00:10:13 UTC) #19
Presubmit check for 10855015-9097 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
 - Changes to chrome/common/extensions/docs/static/events.html not reflected in
generated doc.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py --page-name=<apiName>

Presubmit checks took 16.3s to calculate.

Powered by Google App Engine
This is Rietveld 408576698