Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 10855004: Fix dominatedUsers for phis. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/type_propagation_phi_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/nodes.dart
diff --git a/lib/compiler/implementation/ssa/nodes.dart b/lib/compiler/implementation/ssa/nodes.dart
index 38d94e52371636cce5e4a3b41703e16e48a78331..935d56e48aabe7eadd09cb0323fde6bf0260bb64 100644
--- a/lib/compiler/implementation/ssa/nodes.dart
+++ b/lib/compiler/implementation/ssa/nodes.dart
@@ -975,6 +975,10 @@ class HInstruction implements Hashable {
current = current.next;
}
}
+ // Phis are before [other] too.
kasperl 2012/08/06 10:31:03 Newline before this (to match the rest of the meth
floitsch 2012/08/06 14:05:27 Done.
+ for (HPhi phi = otherBlock.phis.first; phi != null; phi = phi.next) {
kasperl 2012/08/06 10:31:03 !== null
floitsch 2012/08/06 14:05:27 Done.
+ users.remove(phi);
+ }
return users;
}
« no previous file with comments | « no previous file | tests/language/type_propagation_phi_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698