Allow the creation of partially spoofed user agents

content/browser/android/content_view_core_impl.cc

Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index 9b03d894821987f2057d23a94ef415467377369c..eb0a0149c5c53658668d490e630a5559ec10754d 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -27,12 +27,14 @@
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/common/content_client.h"
 #include "content/public/common/page_transition_types.h"
 #include "jni/ContentViewCore_jni.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebBindings.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInputEvent.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/android/WebInputEventFactory.h"
 #include "ui/gfx/android/java_bitmap.h"
+#include "webkit/glue/user_agent.h"
 #include "webkit/glue/webmenuitem.h"
 
 using base::android::AttachCurrentThread;
@@ -95,6 +97,15 @@ ContentViewCoreImpl::ContentViewCoreImpl(JNIEnv* env, jobject obj,
   notification_registrar_.Add(this,
                               NOTIFICATION_EXECUTE_JAVASCRIPT_RESULT,
                               NotificationService::AllSources());
+
+  // Currently, the only use case we have for overriding a user agent involves
+  // spoofing a desktop Linux user agent for "Request desktop site".
+  // Automatically set it for all WebContents.

[Charlie Reis, 2012/08/24 21:38:43]

I don't understand this comment.  Request desktop site isn't on by default, is
it?  Why would this be set for all WebContents?

[gone, 2012/08/24 23:50:35]

The main reason we set it here is that we don't save the user agent override out
in our version of the tab restoration pipeline.  The reasoning for doing so was
to ensure that our override string could report proper Chromium version numbers
while spoofing the rest of the string.  Since there isn't any way to set the
string manually, a user could potentially get stuck with an out-of-date string
until they opened a new tab and surfed with that.  It also saves some storage
space since we always override with the same string, but that's a minor thing.

As a consequence, the override has to be re-set for the WebContents when the
browser restarts; the constructor catches both this case and the case where the
user toggles the overrides on for a tab for the first time.  The alternative is
to set it in both of those locations; I don't have a strong opinion either way
and could switch over, if necessary.

[Charlie Reis, 2012/08/25 00:11:10]

Sorry if I'm just missing something basic, but is this just saying what the
overridden user agent should be if the user decides to use Request Desktop Site?
 (Rather than turning on the override by default?)  If so, please clarify that
in the comment, since I didn't get it.

[gone, 2012/08/25 00:23:49]

D'oh, yeah, that's all that does.  It just sets the string for when it's needed
and doesn't turn it on by default.  I'll clarify in the comment.

+  const char kLinuxInfoStr[] = "X11; Linux x86_64";
+  std::string product = content::GetContentClient()->GetProduct();
+  std::string spoofed_ua =
+      webkit_glue::BuildUserAgentFromOSAndProduct(kLinuxInfoStr, product);
+  web_contents->SetUserAgentOverride(spoofed_ua);
 }
 
 ContentViewCoreImpl::~ContentViewCoreImpl() {