Allow the creation of partially spoofed user agents

content/public/common/content_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_CONTENT_CLIENT_H_
 #define CONTENT_PUBLIC_COMMON_CONTENT_CLIENT_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 90 matching lines @@
       std::vector<std::string>* savable_schemes) {}
 
   // Returns true if the url has a scheme for WebUI.  See also
   // WebUIControllerFactory::UseWebUIForURL in the browser process.
   virtual bool HasWebUIScheme(const GURL& url) const;
 
   // Returns whether the given message should be processed in the browser on
   // behalf of a swapped out renderer.
   virtual bool CanHandleWhileSwappedOut(const IPC::Message& message);
 
+  // Returns a string describing the product.

[Charlie Reis, 2012/08/24 21:38:43]

Can you elaborate on what you mean by "product?"  It's not obvious outside the
context of user agents.

[gone, 2012/08/24 23:50:35]

I pulled the name from the existing GetUserAgent() code.  Would changing the
comment to
"Returns a string describing the embedder version.  Used as part of the user
agent string." make more sense?

[Charlie Reis, 2012/08/25 00:11:10]

Yes, that would help a lot.

[gone, 2012/08/25 00:23:49]

Will set it for the next patch.

+  virtual std::string GetProduct() const;
+
   // Returns the user agent.
   virtual std::string GetUserAgent() const;
 
   // Returns a string resource given its id.
   virtual string16 GetLocalizedString(int message_id) const;
 
   // Return the contents of a resource in a StringPiece given the resource id.
   virtual base::StringPiece GetDataResource(
       int resource_id,
       ui::ScaleFactor scale_factor) const;
@@ skipping 36 matching lines @@
   ContentPluginClient* plugin_;
   // The embedder API for participating in renderer logic.
   ContentRendererClient* renderer_;
   // The embedder API for participating in utility logic.
   ContentUtilityClient* utility_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_CONTENT_CLIENT_H_