Issue 10854234: Remove the testNewTabPdf test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10854234: Remove the testNewTabPdf test. (Closed)

Created:
8 years, 4 months ago by jam

Modified:
8 years, 4 months ago

Reviewers:
dennis_jeffrey, Nirnimesh

CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove the testNewTabPdf test since the pdf data files are going away. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152391

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -10 lines)			Patch
	M	chrome/test/functional/perf.py	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

I'm not sure what this was testing? The pdf will load asynchronously so the time ...

8 years, 4 months ago (2012-08-20 19:48:12 UTC) #1

dennis_jeffrey

8 years, 4 months ago (2012-08-20 21:04:46 UTC) #3

LGTM

I agree that if the PDF is loading asynchronously, the test doesn't make much
sense since we're not including the PDF load time in the results anyway.

Ok with deleting the test for now and will file a bug to investigate re-writing
the test to work accurately (only if there's still a need to measure PDF load
time on chromeOS).

Expand Messages | Collapse Messages