Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 10854234: Remove the testNewTabPdf test. (Closed)

Created:
8 years, 4 months ago by jam
Modified:
8 years, 4 months ago
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Remove the testNewTabPdf test since the pdf data files are going away. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/test/functional/perf.py View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
I'm not sure what this was testing? The pdf will load asynchronously so the time ...
8 years, 4 months ago (2012-08-20 19:48:12 UTC) #1
Nirnimesh
-> Dennis
8 years, 4 months ago (2012-08-20 19:50:22 UTC) #2
dennis_jeffrey
8 years, 4 months ago (2012-08-20 21:04:46 UTC) #3
LGTM

I agree that if the PDF is loading asynchronously, the test doesn't make much
sense since we're not including the PDF load time in the results anyway.

Ok with deleting the test for now and will file a bug to investigate re-writing
the test to work accurately (only if there's still a need to measure PDF load
time on chromeOS).

Powered by Google App Engine
This is Rietveld 408576698