Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 10854208: Adding Element.AddHTML and Element.addText methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Implementing polyfills for insertAdjacent* to get tests working on FF. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « lib/html/dart2js/html_dart2js.dart ('k') | lib/html/doc/interface/Element.dartdoc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/dartium/html_dartium.dart
diff --git a/lib/html/dartium/html_dartium.dart b/lib/html/dartium/html_dartium.dart
index 193777a97bd1343ad9347db35d68ad69374790c6..c609cbda282ae686c95b1e2c674748ec321136c9 100644
--- a/lib/html/dartium/html_dartium.dart
+++ b/lib/html/dartium/html_dartium.dart
@@ -5918,6 +5918,14 @@ class _DocumentFragmentImpl extends _NodeImpl implements DocumentFragment {
this._insertAdjacentNode(where, new DocumentFragment.html(text));
}
+ void addText(String text) {
+ this.insertAdjacentText('beforeend', text);
+ }
+
+ void addHTML(String text) {
+ this.insertAdjacentHTML('beforeend', text);
+ }
+
Future<ElementRect> get rect() {
return _createMeasurementFuture(() => const EmptyElementRect(),
new Completer<ElementRect>());
@@ -7104,14 +7112,14 @@ class _ElementRectImpl implements ElementRect {
// TODO(jacobr): should we move these outside of ElementRect to avoid the
// overhead of computing them every time even though they are rarely used.
- final _ClientRectImpl _boundingClientRect;
+ final _ClientRectImpl _boundingClientRect;
final _ClientRectListImpl _clientRects;
_ElementRectImpl(_ElementImpl element) :
client = new _SimpleClientRect(element.$dom_clientLeft,
element.$dom_clientTop,
- element.$dom_clientWidth,
- element.$dom_clientHeight),
+ element.$dom_clientWidth,
+ element.$dom_clientHeight),
offset = new _SimpleClientRect(element.$dom_offsetLeft,
element.$dom_offsetTop,
element.$dom_offsetWidth,
@@ -7200,6 +7208,14 @@ class _ElementImpl extends _NodeImpl implements Element {
new Completer<CSSStyleDeclaration>());
}
+ void addText(String text) {
+ this.insertAdjacentText('beforeend', text);
+ }
+
+ void addHTML(String text) {
+ this.insertAdjacentHTML('beforeend', text);
+ }
+
// Hooks to support custom WebComponents.
var xtag;
@@ -7212,6 +7228,7 @@ class _ElementImpl extends _NodeImpl implements Element {
}
+
_ElementEventsImpl get on() =>
new _ElementEventsImpl(this);
@@ -26661,6 +26678,17 @@ interface Element extends Node, NodeSelector default _ElementFactoryProvider {
void set dataAttributes(Map<String, String> value);
/**
+ * Adds the specified text as a text node after the last child of this.
+ */
+ void addText(String text);
+
+ /**
+ * Parses the specified text as HTML and adds the resulting node after the
+ * last child of this.
+ */
+ void addHTML(String html);
+
+ /**
* @domName getClientRects, getBoundingClientRect, clientHeight, clientWidth,
* clientTop, clientLeft, offsetHeight, offsetWidth, offsetTop, offsetLeft,
* scrollHeight, scrollWidth, scrollTop, scrollLeft
« no previous file with comments | « lib/html/dart2js/html_dart2js.dart ('k') | lib/html/doc/interface/Element.dartdoc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698