Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10854177: Only set the channel from ExtensionSystem if there hasn't been one set already. (Closed)

Created:
8 years, 4 months ago by not at google - send to devlin
Modified:
8 years, 4 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, benwells, koz (OOO until 15th September)
Visibility:
Public.

Description

Only set the channel from ExtensionSystem if there hasn't been one set already. This should prevent construction of ExtensionSystem in tests from overwriting the ones that tests set. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151801

Patch Set 1 #

Total comments: 2

Patch Set 2 : kDefaultChannel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M chrome/browser/extensions/extension_system.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/extensions/features/feature.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/extensions/features/feature.cc View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
8 years, 4 months ago (2012-08-15 23:10:03 UTC) #1
Matt Perry
lgtm https://chromiumcodereview.appspot.com/10854177/diff/1/chrome/common/extensions/features/feature.cc File chrome/common/extensions/features/feature.cc (right): https://chromiumcodereview.appspot.com/10854177/diff/1/chrome/common/extensions/features/feature.cc#newcode65 chrome/common/extensions/features/feature.cc:65: VersionInfo::Channel g_default_channel = VersionInfo::CHANNEL_STABLE; make it a const? ...
8 years, 4 months ago (2012-08-15 23:13:01 UTC) #2
not at google - send to devlin
https://chromiumcodereview.appspot.com/10854177/diff/1/chrome/common/extensions/features/feature.cc File chrome/common/extensions/features/feature.cc (right): https://chromiumcodereview.appspot.com/10854177/diff/1/chrome/common/extensions/features/feature.cc#newcode65 chrome/common/extensions/features/feature.cc:65: VersionInfo::Channel g_default_channel = VersionInfo::CHANNEL_STABLE; On 2012/08/15 23:13:02, Matt Perry ...
8 years, 4 months ago (2012-08-15 23:16:09 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 23:16:27 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698