Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 10854174: Fixing nacl-mounts breakages. (Closed)

Created:
8 years, 4 months ago by bradn
Modified:
8 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Fixing nacl-mounts breakages. Using default RefCount for sockets. Ppapi has removed the mis-named ThreadSafeRefCount (it wasn't thread safe). Defaulting back to whatever Ppapi picks as the default. Disabling test.nacl for newlib as it doesn't build. (Not sure it ever did?) Removing explicit pathing in Makefile referring to vissi's homedir (the install step should put things in the right include location). BUG=None TEST=builds R=eugenis@google.com,bradchen@google.com Committed: https://code.google.com/p/naclports/source/detail?r=623

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M libraries/nacl-mounts/net/SocketSubSystem.h View 1 1 chunk +1 line, -1 line 0 comments Download
M libraries/nacl-mounts/net/TcpServerSocket.h View 1 1 chunk +1 line, -1 line 0 comments Download
M libraries/nacl-mounts/net/TcpSocket.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M libraries/nacl-mounts/test.nacl/DevTest.cc View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M libraries/nacl-mounts/test.nacl/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
bradn
8 years, 4 months ago (2012-08-15 21:59:17 UTC) #1
jvoung - send to chromium...
On 2012/08/15 21:59:17, bradn wrote: fyi, I think ppapi/utility changed again (in the sdk pepper_canary ...
8 years, 4 months ago (2012-08-16 16:31:16 UTC) #2
eugenis
On 2012/08/16 16:31:16, jvoung wrote: > On 2012/08/15 21:59:17, bradn wrote: > > fyi, I ...
8 years, 4 months ago (2012-08-21 09:54:27 UTC) #3
bradn
Ah, I had let this fall on the floor. Yes, this probably doesn't need to ...
8 years, 4 months ago (2012-08-21 16:33:10 UTC) #4
jvoung - send to chromium...
https://chromiumcodereview.appspot.com/10854174/diff/1/libraries/nacl-mounts/net/TcpSocket.h File libraries/nacl-mounts/net/TcpSocket.h (right): https://chromiumcodereview.appspot.com/10854174/diff/1/libraries/nacl-mounts/net/TcpSocket.h#newcode15 libraries/nacl-mounts/net/TcpSocket.h:15: #include "ppapi/utility/non_thread_safe_ref_count.h" What I meant was that this header ...
8 years, 4 months ago (2012-08-21 16:37:28 UTC) #5
bradn
Yeah seems worse than I thought. Fixing several issues. PTAL
8 years, 4 months ago (2012-08-21 17:30:08 UTC) #6
jvoung - send to chromium...
8 years, 4 months ago (2012-08-21 17:40:23 UTC) #7
LGTM otherwise

https://chromiumcodereview.appspot.com/10854174/diff/3002/libraries/nacl-moun...
File libraries/nacl-mounts/nacl-nacl-mounts.sh (right):

https://chromiumcodereview.appspot.com/10854174/diff/3002/libraries/nacl-moun...
libraries/nacl-mounts/nacl-nacl-mounts.sh:50: if [ $NACL_GLIBC == "1" ] ; then
Actually, this might be fixed by:
https://chromiumcodereview.appspot.com/10828337/

Powered by Google App Engine
This is Rietveld 408576698