Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3473)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 10854169: Closes zoom bubble when tab is changed within a browser window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added comment Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index e18b1183ad24c99b1cd562e194c0d77a7bfe3484..657e03a1fe723894a66153e4c38a3a954136dfac 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -398,6 +398,10 @@ void LocationBarView::ModeChanged(const chrome::search::Mode& old_mode,
void LocationBarView::Update(const WebContents* tab_for_state_restoring) {
RefreshContentSettingViews();
+ // If |tab_for_state_restoring| is non-NULL, a tab change has occurred, so the
+ // zoom bubble should be hidden since it represents the zoom on another tab.
Peter Kasting 2012/08/15 19:40:28 So, if we change URLs within the tab, and the new
Kyle Horimoto 2012/08/15 20:30:19 Actually, you're right. Probably better to get rid
+ if (tab_for_state_restoring != NULL)
+ ZoomBubbleView::CloseBubble();
zoom_view_->Update();
Peter Kasting 2012/08/15 19:40:28 Having this call after CloseBubble() doesn't risk
Kyle Horimoto 2012/08/15 20:30:19 Nope!
RefreshPageActionViews();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698