Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 10854168: [NaCl SDK] Nicer display for 'naclsdk list' (Closed)

Created:
8 years, 4 months ago by binji
Modified:
8 years, 4 months ago
Reviewers:
noelallen1
CC:
chromium-reviews, pam+watch_chromium.org, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] Nicer display for 'naclsdk list' Also added 'naclsdk info' command to display more info about a bundle. Also fixed bug when running 'naclsdk -h' (auto updater bug). BUG=140361 NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152109

Patch Set 1 #

Total comments: 4

Patch Set 2 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -15 lines) Patch
M native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py View 1 6 chunks +103 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
binji
"naclsdk list" looks like this now: Bundles: I: installed *: update available I sdk_tools (stable) ...
8 years, 4 months ago (2012-08-15 19:16:52 UTC) #1
noelallen1
Couple nits, otherwise LGTM http://codereview.chromium.org/10854168/diff/1/native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py File native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py (right): http://codereview.chromium.org/10854168/diff/1/native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py#newcode38 native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py:38: info - Displas information about ...
8 years, 4 months ago (2012-08-15 21:33:35 UTC) #2
binji
http://codereview.chromium.org/10854168/diff/1/native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py File native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py (right): http://codereview.chromium.org/10854168/diff/1/native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py#newcode38 native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py:38: info - Displas information about a bundle On 2012/08/15 ...
8 years, 4 months ago (2012-08-15 23:12:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/10854168/4001
8 years, 4 months ago (2012-08-17 18:10:31 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 18:12:05 UTC) #5
Change committed as 152109

Powered by Google App Engine
This is Rietveld 408576698