Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10854158: Make selector registration in the resolver and code generator more explicit. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/builder.dart
diff --git a/lib/compiler/implementation/ssa/builder.dart b/lib/compiler/implementation/ssa/builder.dart
index fae30e27db03de34ff5af27137d4e76e7d4c6eb7..cd3d382866dc5e0d3e5aa1efd604593d27e9e541 100644
--- a/lib/compiler/implementation/ssa/builder.dart
+++ b/lib/compiler/implementation/ssa/builder.dart
@@ -2165,7 +2165,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
// If the isolate library is not used, we just invoke the
// closure.
visit(link.tail.head);
- Selector selector = new Selector.callAny(0);
+ Selector selector = new Selector.callClosure(0);
push(new HInvokeClosure(selector, <HInstruction>[pop()]));
} else {
// Call a helper method from the isolate library.
@@ -2205,7 +2205,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
visit(closure);
List<HInstruction> inputs = <HInstruction>[pop()];
String invocationName = compiler.namer.closureInvocationName(
- new Selector.callAny(params.requiredParameterCount));
+ new Selector.callClosure(params.requiredParameterCount));
push(new HForeign(new DartString.literal('#.$invocationName'),
const LiteralDartString('var'),
inputs));

Powered by Google App Engine
This is Rietveld 408576698