Make selector registration in the resolver and code generator more explicit.

lib/compiler/implementation/enqueue.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class EnqueueTask extends CompilerTask {
   final Enqueuer codegen;
   final Enqueuer resolution;
 
   String get name() => 'Enqueue';
 
@@ skipping 125 matching lines @@
         }
       }
     });
     return true;
   }
 
   void processInstantiatedClass(ClassElement cls) {
     cls.localMembers.forEach(processInstantiatedClassMember);
   }
 
-  void registerFieldClosureInvocations() {
-    task.measure(() {
-      // Make sure that the closure understands a call with the given
-      // selector. For a method-invocation of the form o.foo(a: 499), we
-      // need to make sure that closures can handle the optional argument if
-      // there exists a field or getter 'foo'.
-      var names = universe.instantiatedClassInstanceFields;
-      // TODO(ahe): Might be enough to use invokedGetters.
-      for (SourceString name in names) {
-        Set<Selector> invokedSelectors = universe.invokedNames[name];
-        if (invokedSelectors != null) {
-          for (Selector selector in invokedSelectors) {
-            Selector call = new Selector.call(
-                compiler.namer.CLOSURE_INVOCATION_NAME,
-                selector.library,  // TODO(kasperl): Use "default" library?
-                selector.argumentCount,
-                selector.namedArguments);
-            registerDynamicInvocation(compiler.namer.CLOSURE_INVOCATION_NAME,
-                                      call);
-          }
-        }
-      }
-    });
-  }
-
   void processInstantiatedClassMember(Element member) {
     if (universe.generatedCode.containsKey(member)) return;
     if (resolvedElements[member] !== null) return;
 
     if (!member.isInstanceMember()) return;
     if (member.isField()) return;
 
     String memberName = member.name.slowToString();
     Link<Element> members = instanceMembersByName.putIfAbsent(
         memberName, () => const EmptyLink<Element>());
@@ skipping 161 matching lines @@
     });
   }
 
   // TODO(ngeoffray): This should get a type.
   void registerIsCheck(Element element) {
     universe.isChecks.add(element);
   }
 
   void forEach(f(WorkItem work)) {
     while (!queue.isEmpty()) {
       do {

[floitsch, 2012/08/15 14:14:04]

remove the inner loop.

[ahe, 2012/08/15 14:32:21]

Remove this loop.

[kasperl, 2012/08/16 10:35:47]

Done.

[kasperl, 2012/08/16 10:35:47]

Done.

         f(queue.removeLast());
       } while (!queue.isEmpty());
-      // TODO(ahe): we shouldn't register the field closure invocations here.
-      registerFieldClosureInvocations();

[ahe, 2012/08/15 14:32:21]

Yay!

     }
   }
 }