Allow `pub install` and `pub update` to update dependers.

utils/tests/pub/pub_test.dart

Index: utils/tests/pub/pub_test.dart
diff --git a/utils/tests/pub/pub_test.dart b/utils/tests/pub/pub_test.dart
index ca65c1d9c7b077e1f082b4b83f7ca190d0e00099..73f44df4be358b57cdd4fb63117eb4ba94c5fe26 100644
--- a/utils/tests/pub/pub_test.dart
+++ b/utils/tests/pub/pub_test.dart
@@ -868,6 +868,134 @@ dependencies:
 
     run();
   });
+
+  test("unlocks dependencies if necessary to ensure that a new dependency "
+      "is satisfied", () {

[Bob Nystrom, 2012/08/15 17:48:16]

I'd like to also have a test to ensure that dependencies are *not* unlocked if a
new dependency doesn't require it. I.e. if newdep here allowed baz 1.0.0, then
everything should have stayed at its current version, right?

Also, how about tweaking this test to validate that only necessary packages are
unlocked? This test would pass if the algorithm was simply "if a constraint
fails unlock the whole world", which isn't what we want.

I think if you just make newdep depend on bar instead of baz, you could then
validate that baz is still at 1.0.0.

[nweiz, 2012/08/15 21:25:42]

Done.
That would work, but it would no longer validate that the unlocking happens
recursively more than one step back. In order to test that as well, I'll just
add another layer.

+    servePackages("localhost", 3123, [
+      '''
+name: foo
+version: 1.0.0
+dependencies:
+  bar:
+    version: "<2.0.0"
+    repo: {name: bar, url: http://localhost:3123}
+''',
+      '''
+name: bar
+version: 1.0.0
+dependencies:
+  baz:
+    version: "<2.0.0"
+    repo: {name: baz, url: http://localhost:3123}
+''',
+    '''
+name: baz
+version: 1.0.0
+''']);
+
+    dir(appPath, [
+      file('pubspec.yaml', '''
+dependencies:
+  foo:
+    repo: {name: foo, url: http://localhost:3123}
+''')
+    ]).scheduleCreate();
+
+    schedulePub(args: ['install'],
+        output: const RegExp(@"Dependencies installed!$"));
+
+    dir(packagesPath, [
+      dir('foo', [
+        file('foo.dart', 'main() => print("foo 1.0.0");')
+      ]),
+      dir('bar', [
+        file('bar.dart', 'main() => print("bar 1.0.0");')
+      ]),
+      dir('baz', [
+        file('baz.dart', 'main() => print("baz 1.0.0");')
+      ])
+    ]).scheduleValidate();
+
+    servePackages("localhost", 3123, [
+      '''
+name: foo
+version: 1.0.0
+dependencies:
+  bar:
+    version: "<2.0.0"
+    repo: {name: bar, url: http://localhost:3123}
+''',
+      '''
+name: foo
+version: 2.0.0
+dependencies:
+  bar:
+    version: "<3.0.0"
+    repo: {name: bar, url: http://localhost:3123}
+''',
+      '''
+name: bar
+version: 1.0.0
+dependencies:
+  baz:
+    version: "<2.0.0"
+    repo: {name: baz, url: http://localhost:3123}
+''',
+      '''
+name: bar
+version: 2.0.0
+dependencies:
+  baz:
+    version: "<3.0.0"
+    repo: {name: baz, url: http://localhost:3123}
+''',
+    '''
+name: baz
+version: 1.0.0
+''',
+    '''
+name: baz
+version: 2.0.0
+''',
+    '''
+name: newdep
+version: 2.0.0
+dependencies:
+  baz:
+    version: ">=1.5.0"
+    repo: {name: baz, url: http://localhost:3123}
+''']);
+
+    dir(appPath, [
+      file('pubspec.yaml', '''
+dependencies:
+  foo:
+    repo: {name: foo, url: http://localhost:3123}
+  newdep:
+    repo: {name: newdep, url: http://localhost:3123}
+''')
+    ]).scheduleCreate();
+
+    schedulePub(args: ['install'],
+        output: const RegExp(@"Dependencies installed!$"));
+
+    dir(packagesPath, [
+      dir('foo', [
+        file('foo.dart', 'main() => print("foo 2.0.0");')

[Bob Nystrom, 2012/08/15 17:48:16]

Since servePackages() automatically generates these package contents, maybe we
should have a corresponding helper for validating them too. It seems a bit weird
to look for "print(...)" here when the code defining that isn't in the test.
Maybe something like:

dir(packagesPath, [
  pkg('foo', '2.0.0'),
  pkg('bar', '2.0.0'),
  pkg('baz', '2.0.0'),
  pkg('newdep', '2.0.0')
]).scheduleValidate();

This doesn't need to be in this patch, but it's something to think about.

[nweiz, 2012/08/15 21:25:42]

I agree. I'm vaguely planning on doing a test clean-up patch sometime soon.

+      ]),
+      dir('bar', [
+        file('bar.dart', 'main() => print("bar 2.0.0");')
+      ]),
+      dir('baz', [
+        file('baz.dart', 'main() => print("baz 2.0.0");')
+      ]),
+      dir('newdep', [
+        file('newdep.dart', 'main() => print("newdep 2.0.0");')
+      ])
+    ]).scheduleValidate();
+
+    run();
+  });
 }
 
 updateCommand() {
@@ -1139,6 +1267,78 @@ dependencies:
 
       run();
     });
+
+    test("updates a locked package's dependers in order to get it to max "
+        "version", () {
+      servePackages("localhost", 3123, [
+        '''
+name: foo
+version: 1.0.0
+dependencies:
+  bar:
+    version: "<2.0.0"
+    repo: {name: bar, url: http://localhost:3123}
+''',
+        '{name: bar, version: 1.0.0}'
+      ]);
+
+      dir(appPath, [
+        file('pubspec.yaml', '''
+dependencies:
+  foo:
+    repo: {name: foo, url: http://localhost:3123}
+  bar:
+    repo: {name: bar, url: http://localhost:3123}
+''')
+      ]).scheduleCreate();
+
+      schedulePub(args: ['install'],
+          output: const RegExp(@"Dependencies installed!$"));
+
+      dir(packagesPath, [
+        dir('foo', [
+          file('foo.dart', 'main() => print("foo 1.0.0");'),
+        ]),
+        dir('bar', [
+          file('bar.dart', 'main() => print("bar 1.0.0");')
+        ])
+      ]).scheduleValidate();
+
+      servePackages("localhost", 3123, [
+        '''
+name: foo
+version: 1.0.0
+dependencies:
+  bar:
+    version: "<2.0.0"
+    repo: {name: bar, url: http://localhost:3123}
+''',
+        '''
+name: foo
+version: 2.0.0
+dependencies:
+  bar:
+    version: "<3.0.0"
+    repo: {name: bar, url: http://localhost:3123}
+''',
+        '{name: bar, version: 1.0.0}',
+        '{name: bar, version: 2.0.0}'
+      ]);
+
+      schedulePub(args: ['update', 'bar'],
+          output: const RegExp(@"Dependencies updated!$"));
+
+      dir(packagesPath, [
+        dir('foo', [
+          file('foo.dart', 'main() => print("foo 2.0.0");'),
+        ]),
+        dir('bar', [
+          file('bar.dart', 'main() => print("bar 2.0.0");')
+        ])
+      ]).scheduleValidate();
+
+      run();
+    });
   });
 }