Cocoa: Media gallery dialog unit test

Cocoa: Media gallery dialog unit test

This is a port of the GTK unit test:
http://codereview.chromium.org/10823303/

BUG=134929
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152272

[Nico, 2012-08-14 21:23:36]

https://chromiumcodereview.appspot.com/10854150/diff/1/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_unittest.mm
(right):

https://chromiumcodereview.appspot.com/10854150/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_unittest.mm:13:
public MediaGalleriesDialogController {
It's confusing me that the test fixture class is a fake MGDController at the
same time. Could you separate them into two classes? (and if the MGDC fake is
doing similar things in the gtk test, possibly share it between the gtk and
cocoa tests)?

[sail, 2012-08-15 22:40:06]

updated to use mocks, please take another look

[Evan Stade, 2012-08-15 23:01:00]

nice, I like. GTK lgtm.

http://codereview.chromium.org/10854150/diff/8001/chrome/browser/ui/gtk/exten...
File chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk_unittest.cc
(right):

http://codereview.chromium.org/10854150/diff/8001/chrome/browser/ui/gtk/exten...
chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk_unittest.cc:40:
dialog_(new MediaGalleriesDialogGtk(&controller));
it strikes me that this doesn't need to be a scoped_ptr, it can be
stack-allocated.

[Evan Stade, 2012-08-15 23:01:25]

On 2012/08/15 23:01:00, Evan Stade wrote:
> nice, I like. GTK lgtm.

as well as the media_gallery/ part.

[sail, 2012-08-15 23:07:31]

https://chromiumcodereview.appspot.com/10854150/diff/8001/chrome/browser/ui/g...
File chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk_unittest.cc
(right):

https://chromiumcodereview.appspot.com/10854150/diff/8001/chrome/browser/ui/g...
chrome/browser/ui/gtk/extensions/media_galleries_dialog_gtk_unittest.cc:40:
dialog_(new MediaGalleriesDialogGtk(&controller));
On 2012/08/15 23:01:00, Evan Stade wrote:
> it strikes me that this doesn't need to be a scoped_ptr, it can be
> stack-allocated.

Done.

[Nico, 2012-08-15 23:09:12]

lgtm

[commit-bot: I haz the power, 2012-08-17 21:42:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/10854150/13001

[commit-bot: I haz the power, 2012-08-17 22:37:27]

Try job failure for 10854150-13001 (retry) on linux_rel for step "unit_tests".
It's a second try, previously, step "unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-18 00:50:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/10854150/7010

[commit-bot: I haz the power, 2012-08-18 02:18:04]

Try job failure for 10854150-7010 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-18 23:45:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/10854150/7010

[commit-bot: I haz the power, 2012-08-19 02:09:36]

Change committed as 152272