content/common/gpu/media/omx_video_decode_accelerator.h - Issue 10854146: Always call OMX_FreeBuffer(), even in ERRORING.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/omx_video_decode_accelerator.h

Issue 10854146: Always call OMX_FreeBuffer(), even in ERRORING. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/omx_video_decode_accelerator.h

diff --git a/content/common/gpu/media/omx_video_decode_accelerator.h b/content/common/gpu/media/omx_video_decode_accelerator.h

index 10beb7990ee90e1c743f86ebfd824a6903446d84..761ff105a5a59ebe56561cb8b5323b2c98554852 100644

--- a/content/common/gpu/media/omx_video_decode_accelerator.h

+++ b/content/common/gpu/media/omx_video_decode_accelerator.h

@@ -103,8 +103,7 @@ class CONTENT_EXPORT OmxVideoDecodeAccelerator :

bool AllocateInputBuffers();

bool AllocateFakeOutputBuffers();

bool AllocateOutputBuffers();

- void FreeInputBuffers();

- void FreeOutputBuffers();

+ void FreeOMXBuffers();

// Methods to handle OMX state transitions. See section 3.1.1.2 of the spec.

// Request transitioning OMX component to some other state.