Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10854137: [NaCl SDK] gtest_ppapi library. (Closed)

Created:
8 years, 4 months ago by binji
Modified:
8 years, 4 months ago
Reviewers:
noelallen1
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

[NaCl SDK] gtest_ppapi library. Right now it is just c_salt/test moved over, but the goal is to use this to allow gtest to forward test results to the browser, and from there to a local server. BUG=none NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151620

Patch Set 1 #

Patch Set 2 : remove hacks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -962 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 1 chunk +1 line, -0 lines 0 comments Download
D native_client_sdk/src/libraries/build.scons View 1 chunk +0 lines, -41 lines 0 comments Download
D native_client_sdk/src/libraries/c_salt/test/gtest_event_listener.h View 1 chunk +0 lines, -51 lines 0 comments Download
D native_client_sdk/src/libraries/c_salt/test/gtest_event_listener.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D native_client_sdk/src/libraries/c_salt/test/gtest_instance.h View 1 chunk +0 lines, -34 lines 0 comments Download
D native_client_sdk/src/libraries/c_salt/test/gtest_instance.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D native_client_sdk/src/libraries/c_salt/test/gtest_module.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D native_client_sdk/src/libraries/c_salt/test/gtest_nacl_environment.h View 1 chunk +0 lines, -39 lines 0 comments Download
D native_client_sdk/src/libraries/c_salt/test/gtest_nacl_environment.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D native_client_sdk/src/libraries/c_salt/test/gtest_runner.h View 1 chunk +0 lines, -62 lines 0 comments Download
D native_client_sdk/src/libraries/c_salt/test/gtest_runner.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D native_client_sdk/src/libraries/c_salt/threading/condition_lock.h View 1 chunk +0 lines, -89 lines 0 comments Download
D native_client_sdk/src/libraries/c_salt/threading/pthread_ext.h View 1 chunk +0 lines, -15 lines 0 comments Download
D native_client_sdk/src/libraries/c_salt/threading/ref_count.h View 1 chunk +0 lines, -46 lines 0 comments Download
D native_client_sdk/src/libraries/c_salt/threading/scoped_mutex_lock.h View 1 chunk +0 lines, -32 lines 0 comments Download
D native_client_sdk/src/libraries/c_salt/threading/thread_condition.h View 1 chunk +0 lines, -76 lines 0 comments Download
A + native_client_sdk/src/libraries/gtest_ppapi/condition_lock.h View 2 chunks +2 lines, -5 lines 0 comments Download
A + native_client_sdk/src/libraries/gtest_ppapi/gtest_event_listener.h View 2 chunks +7 lines, -11 lines 0 comments Download
A + native_client_sdk/src/libraries/gtest_ppapi/gtest_event_listener.cc View 2 chunks +1 line, -6 lines 0 comments Download
A + native_client_sdk/src/libraries/gtest_ppapi/gtest_instance.h View 2 chunks +3 lines, -8 lines 0 comments Download
A + native_client_sdk/src/libraries/gtest_ppapi/gtest_instance.cc View 4 chunks +4 lines, -9 lines 0 comments Download
A + native_client_sdk/src/libraries/gtest_ppapi/gtest_module.cc View 2 chunks +5 lines, -8 lines 0 comments Download
A + native_client_sdk/src/libraries/gtest_ppapi/gtest_nacl_environment.h View 3 chunks +3 lines, -8 lines 0 comments Download
A + native_client_sdk/src/libraries/gtest_ppapi/gtest_nacl_environment.cc View 2 chunks +1 line, -6 lines 0 comments Download
A + native_client_sdk/src/libraries/gtest_ppapi/gtest_runner.h View 2 chunks +6 lines, -11 lines 0 comments Download
A + native_client_sdk/src/libraries/gtest_ppapi/gtest_runner.cc View 3 chunks +7 lines, -11 lines 0 comments Download
A native_client_sdk/src/libraries/gtest_ppapi/library.dsc View 1 chunk +35 lines, -0 lines 0 comments Download
A + native_client_sdk/src/libraries/gtest_ppapi/pthread_ext.h View 2 chunks +3 lines, -4 lines 0 comments Download
A + native_client_sdk/src/libraries/gtest_ppapi/ref_count.h View 2 chunks +4 lines, -8 lines 0 comments Download
A + native_client_sdk/src/libraries/gtest_ppapi/scoped_mutex_lock.h View 2 chunks +4 lines, -7 lines 0 comments Download
A + native_client_sdk/src/libraries/gtest_ppapi/thread_condition.h View 2 chunks +4 lines, -9 lines 0 comments Download
D native_client_sdk/src/libraries/scons View 1 chunk +0 lines, -47 lines 0 comments Download
D native_client_sdk/src/libraries/scons.bat View 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
binji
8 years, 4 months ago (2012-08-14 17:40:54 UTC) #1
noelallen1
Rubber stamp LGTM for moved files, deleted files. Change to build_sdk also looks good.
8 years, 4 months ago (2012-08-14 18:14:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/10854137/3001
8 years, 4 months ago (2012-08-15 01:01:42 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 01:02:31 UTC) #4 
Change committed as 151620

Powered by Google App Engine
This is Rietveld 408576698