Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: chrome/browser/resources/options2/browser_options.js

Issue 10854126: Show an extra privacy warning on Win8 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Only have the win8 privacy div when running on Windows. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/browser_options.js
diff --git a/chrome/browser/resources/options2/browser_options.js b/chrome/browser/resources/options2/browser_options.js
index e0acdb745c6da8bcccdded3af1c293138a8b7fa6..3ebf7ddb5cea1766cab47f5597e9da62c4ac9c23 100644
--- a/chrome/browser/resources/options2/browser_options.js
+++ b/chrome/browser/resources/options2/browser_options.js
@@ -1191,6 +1191,14 @@ cr.define('options', function() {
},
/**
+ * Show/hide Windows 8 data privacy warning.
+ * @private
+ */
+ showWin8DataPrivacy_: function() {
+ $('privacy-win8-data-settings').hidden = false;
arv (Not doing code reviews) 2012/08/15 14:33:31 How about, in initializePage we do: var m = /Wind
MAD 2012/08/15 19:29:41 Ho! Cool, I didn't think about that... Thanks!...
+ },
+
+ /**
* Show/hide the display options button on the System settings page.
* @private
*/
@@ -1318,6 +1326,7 @@ cr.define('options', function() {
'showDisplayOptions',
'showMouseControls',
'showTouchpadControls',
+ 'showWin8DataPrivacy',
'updateAccountPicture',
'updateAutoLaunchState',
'updateDefaultBrowserState',

Powered by Google App Engine
This is Rietveld 408576698