Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 10854122: Fixed failing DCHECK on connector start. (Closed)

Created:
8 years, 4 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 4 months ago
Reviewers:
Sergey Ulanov, gene
CC:
chromium-reviews
Visibility:
Public.

Description

Added TransportSecurityState to URLRequestContextStorage used in cloud print connector. BUG=141932 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151331

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/service/net/service_url_request_context.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Vitaly Buka (NO REVIEWS)
Hi Sergey. Please take a look. If you disagree with patch, please help me to ...
8 years, 4 months ago (2012-08-13 17:11:38 UTC) #1
Sergey Ulanov
https://chromiumcodereview.appspot.com/10854122/diff/1/jingle/glue/xmpp_client_socket_factory.cc File jingle/glue/xmpp_client_socket_factory.cc (left): https://chromiumcodereview.appspot.com/10854122/diff/1/jingle/glue/xmpp_client_socket_factory.cc#oldcode51 jingle/glue/xmpp_client_socket_factory.cc:51: DCHECK(context.transport_security_state); transport_security_state is used for HSTS (http://dev.chromium.org/sts). HSTS limits ...
8 years, 4 months ago (2012-08-13 17:48:47 UTC) #2
Vitaly Buka (NO REVIEWS)
Done.
8 years, 4 months ago (2012-08-13 18:19:45 UTC) #3
Sergey Ulanov
LGTM
8 years, 4 months ago (2012-08-13 18:28:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10854122/3001
8 years, 4 months ago (2012-08-13 18:36:33 UTC) #5
commit-bot: I haz the power
Presubmit check for 10854122-3001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-13 18:36:40 UTC) #6
Vitaly Buka (NO REVIEWS)
8 years, 4 months ago (2012-08-13 18:37:50 UTC) #7
gene
lgtm
8 years, 4 months ago (2012-08-13 18:38:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10854122/3001
8 years, 4 months ago (2012-08-13 18:40:09 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-13 20:14:58 UTC) #10
Change committed as 151331

Powered by Google App Engine
This is Rietveld 408576698