Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Issue 10854121: Fixes for handling of MockDBusThreadManager::GetSystemBus(). (Closed)

Created:
8 years, 4 months ago by satorux1
Modified:
8 years, 4 months ago
Reviewers:
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Fixes for handling of MockDBusThreadManager::GetSystemBus(). This is a patch taken over from zel's original patch: http://codereview.chromium.org/10832258/ BUG=131915 TEST=NetworkScreenTest.* and number of other tests should start passing in BVT CrOS tests TBR=zelidrag@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151336

Patch Set 1 #

Patch Set 2 : fix the build #

Patch Set 3 : fix the build for sure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -23 lines) Patch
M chrome/browser/chromeos/bluetooth/bluetooth_device.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_network_functions_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/dbus/cros_dbus_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/network_screen_browsertest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker_browsertest.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/update_screen_browsertest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/signed_settings_helper_unittest.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/signed_settings_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/display/output_configurator.cc View 2 chunks +22 lines, -18 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
satorux1
8 years, 4 months ago (2012-08-13 19:36:04 UTC) #1
Patch Set contains zel's original patch. Patch Set 2 and 3 fixed the build
errors. The changes were pretty minor.

Powered by Google App Engine
This is Rietveld 408576698