Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 10854117: Files app should not reload when images are dragged into it. (Closed)

Created:
8 years, 4 months ago by SeRya
Modified:
8 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Files app should not reload when images are dragged into it. BUG=137981 TEST=Test that dropping image from third party page has no effect. Test that files from other file manager windows do drop. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151262

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
SeRya
8 years, 4 months ago (2012-08-13 12:52:57 UTC) #1
dgozman
LGTM https://chromiumcodereview.appspot.com/10854117/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/10854117/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode565 chrome/browser/resources/file_manager/js/file_manager.js:565: this.dialogDom_.addEventListener('drop', function(e) { Do we have a separate ...
8 years, 4 months ago (2012-08-13 13:00:30 UTC) #2
SeRya
https://chromiumcodereview.appspot.com/10854117/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/10854117/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode565 chrome/browser/resources/file_manager/js/file_manager.js:565: this.dialogDom_.addEventListener('drop', function(e) { On 2012/08/13 13:00:30, dgozman wrote: > ...
8 years, 4 months ago (2012-08-13 13:21:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10854117/1
8 years, 4 months ago (2012-08-13 13:22:56 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-13 14:54:00 UTC) #5
Change committed as 151262

Powered by Google App Engine
This is Rietveld 408576698