Issue 10854115: Check for function in %_CallFunction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10854115: Check for function in %_CallFunction. (Closed)

Created:
8 years, 4 months ago by Yang

Modified:
8 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -22 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
A +	test/mjsunit/regress/regress-2285.js	View	1 chunk	+2 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

Michael Starzinger

8 years, 4 months ago (2012-08-13 12:07:00 UTC) #2

LGTM. If it doesn't affect performance. But I guess the additional Smi check is
not a huge overhead.