Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10854107: Add linux/mac gamepad mappings for SmartJoy PLUS adapter. (Closed)

Created:
8 years, 4 months ago by jpd
Modified:
8 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Add linux/mac gamepad mappings for SmartJoy PLUS adapter. BUG=141119 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151501

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M content/browser/gamepad/gamepad_standard_mappings_linux.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/gamepad/gamepad_standard_mappings_mac.mm View 3 4 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
lgtm other than rename. Thanks! https://chromiumcodereview.appspot.com/10854107/diff/1003/content/browser/gamepad/gamepad_standard_mappings_linux.cc File content/browser/gamepad/gamepad_standard_mappings_linux.cc (right): https://chromiumcodereview.appspot.com/10854107/diff/1003/content/browser/gamepad/gamepad_standard_mappings_linux.cc#newcode128 content/browser/gamepad/gamepad_standard_mappings_linux.cc:128: { "0925", "0005", MapperMP8866 ...
8 years, 4 months ago (2012-08-13 16:26:05 UTC) #1
jpd
https://chromiumcodereview.appspot.com/10854107/diff/1003/content/browser/gamepad/gamepad_standard_mappings_linux.cc File content/browser/gamepad/gamepad_standard_mappings_linux.cc (right): https://chromiumcodereview.appspot.com/10854107/diff/1003/content/browser/gamepad/gamepad_standard_mappings_linux.cc#newcode128 content/browser/gamepad/gamepad_standard_mappings_linux.cc:128: { "0925", "0005", MapperMP8866 }, // SmartJoy PLUS Adapter ...
8 years, 4 months ago (2012-08-14 02:13:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jpd@google.com/10854107/2004
8 years, 4 months ago (2012-08-14 04:36:07 UTC) #3
commit-bot: I haz the power
Try job failure for 10854107-2004 (retry) on linux_chromeos for steps "browser_tests, content_browsertests". It's a second ...
8 years, 4 months ago (2012-08-14 08:09:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jpd@google.com/10854107/2004
8 years, 4 months ago (2012-08-14 15:08:34 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 17:24:03 UTC) #6 
Change committed as 151501

Powered by Google App Engine
This is Rietveld 408576698