mac: Change gcapi to not install keystone

chrome/installer/gcapi_mac/gcapi.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/gcapi_mac/gcapi.h"
 
 #import <Cocoa/Cocoa.h>
 #include <sys/stat.h>
 #include <sys/types.h>
 #include <sys/utsname.h>
@@ skipping 16 matching lines @@
 
 NSString* const kSystemMasterPrefsPath =
     @"/Library/Google/Google Chrome Master Preferences";
 NSString* const kUserMasterPrefsPath =
     @"~/Library/Application Support/Google/Google Chrome Master Preferences";
 
 NSString* const kChannelKey = @"KSChannelID";
 NSString* const kVersionKey = @"KSVersion";
 
 // Condensed from chromium's base/mac/mac_util.mm.
-bool IsOSXLeopardOrLater() {
+bool IsOSXVersionSupported() {
   // On 10.6, Gestalt() was observed to be able to spawn threads (see
   // http://crbug.com/53200). Don't call Gestalt().
   struct utsname uname_info;
   if (uname(&uname_info) != 0)
     return false;
   if (strcmp(uname_info.sysname, "Darwin") != 0)
     return false;
 
   char* dot = strchr(uname_info.release, '.');
   if (!dot)
     return false;
 
   int darwin_major_version = atoi(uname_info.release);
   if (darwin_major_version < 6)
     return false;
 
   // The Darwin major version is always 4 greater than the Mac OS X minor
   // version for Darwin versions beginning with 6, corresponding to Mac OS X
   // 10.2.
   int mac_os_x_minor_version = darwin_major_version - 4;
 
-  return mac_os_x_minor_version >= 5;
+  // Chrome is known to work on 10.6 - 10.8.
+  return mac_os_x_minor_version >= 6 && mac_os_x_minor_version <= 8;
 }
 
 enum TicketKind {
   kSystemTicket, kUserTicket
 };
 
 BOOL HasChromeTicket(TicketKind kind) {
   // Don't use Objective-C 2 loop syntax, in case an installer runs on 10.4.
   NSMutableArray* keystonePaths =
       [NSMutableArray arrayWithObject:kSystemKsadminPath];
@@ skipping 127 matching lines @@
       stringByAppendingPathComponent:@"Contents/Versions"]
       stringByAppendingPathComponent:version]
       stringByAppendingPathComponent:@"Google Chrome Framework.framework"];
 }
 
 NSString* PathToInstallScript(NSString* app_path, NSDictionary* info_plist) {
   return [PathToFramework(app_path, info_plist) stringByAppendingPathComponent:
       @"Resources/install.sh"];
 }
 
-NSString* PathToKeystoneResources(
-    NSString* app_path, NSDictionary* info_plist) {
-  return [PathToFramework(app_path, info_plist) stringByAppendingPathComponent:
-      @"Frameworks/KeystoneRegistration.framework/Resources"];
-}
-
-NSString* FindOrInstallKeystone(NSString* app_path, NSDictionary* info_plist) {
-  NSString* ks_path = kSystemKsadminPath;
-
-  // Use user Keystone only if system Keystone doesn't exist /
-  // isn't accessible.
-  if (geteuid() != 0 &&
-      ![[NSFileManager defaultManager] isExecutableFileAtPath:ks_path]) {
-    ks_path = [kUserKsadminPath stringByExpandingTildeInPath];
-  }
-
-  // Always run install.py. It won't overwrite an existing keystone, but
-  // it might update it or repair a broken existing installation.
-  NSString* ks_resources = PathToKeystoneResources(app_path, info_plist);
-  NSString* ks_install =
-      [ks_resources stringByAppendingPathComponent:@"install.py"];
-  NSString* ks_tbz =
-      [ks_resources stringByAppendingPathComponent:@"Keystone.tbz"];
-  @try {
-    NSTask* task = [[[NSTask alloc] init] autorelease];
-    [task setLaunchPath:ks_install];
-    [task setArguments:@[@"--install", ks_tbz]];
-    [task launch];
-    [task waitUntilExit];
-    if ([task terminationStatus] == 0)
-      return ks_path;
-  }
-  @catch (id exception) {
-    // Ignore.
-  }
-  return nil;
-}
-
 bool isbrandchar(int c) {
   // Always four upper-case alpha chars.
   return c >= 'A' && c <= 'Z';
 }
 
 }  // namespace
 
 int GoogleChromeCompatibilityCheck(unsigned* reasons) {
   unsigned local_reasons = 0;
 
   NSAutoreleasePool* pool = [[NSAutoreleasePool alloc] init];
 
-  if (!IsOSXLeopardOrLater())
+  if (!IsOSXVersionSupported())
     local_reasons |= GCCC_ERROR_OSNOTSUPPORTED;
 
   if (HasChromeTicket(kSystemTicket))
     local_reasons |= GCCC_ERROR_SYSTEMLEVELALREADYPRESENT;
 
   if (geteuid() != 0 && HasChromeTicket(kUserTicket))
     local_reasons |= GCCC_ERROR_USERLEVELALREADYPRESENT;
 
   if (![[NSFileManager defaultManager] isWritableFileAtPath:@"/Applications"])
     local_reasons |= GCCC_ERROR_ACCESSDENIED;
@@ skipping 53 matching lines @@
         isbrandchar(brand_code[2]) && isbrandchar(brand_code[3]);
 
     NSString* brand_path = nil;
     if (valid_brand_code)
       brand_path = WriteBrandCode(brand_code);
 
     // Write master prefs.
     if (master_prefs_contents)
       WriteMasterPrefs(master_prefs_contents, master_prefs_contents_size);
 
-    // Install Keystone if necessary.
-    if (NSString* keystone = FindOrInstallKeystone(app_path, info_plist)) {
-      // Register Chrome with Keystone.
-      @try {
-        NSTask* task = [[[NSTask alloc] init] autorelease];
-        [task setLaunchPath:keystone];
-        NSString* tag = [info_plist objectForKey:kChannelKey];
-        [task setArguments:@[
-            @"--register",
-            @"--productid", [info_plist objectForKey:@"KSProductID"],
-            @"--version", [info_plist objectForKey:kVersionKey],
-            @"--xcpath", kChromeInstallPath,
-            @"--url", [info_plist objectForKey:@"KSUpdateURL"],
-
-            @"--tag", tag ? tag : @"",  // Stable channel
-            @"--tag-path", info_plist_path,
-            @"--tag-key", kChannelKey,
-
-            @"--brand-path", brand_path ? brand_path : @"",
-            @"--brand-key", brand_path ? kBrandKey: @"",
-
-            @"--version-path", info_plist_path,
-            @"--version-key", kVersionKey,
-        ]];
-        [task launch];
-        [task waitUntilExit];
-      }
-      @catch (id exception) {
-        // Chrome will try to register keystone on launch.
-      }
-    }
-
     // TODO Set default browser if requested. Will be tricky when running as
     // root.
   }
   return 1;
 }
 
 int LaunchGoogleChrome() {
   @autoreleasepool {
     return [[NSWorkspace sharedWorkspace] launchApplication:kChromeInstallPath];
   }
 }