Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: chrome/browser/autofill/DEPS

Issue 10854095: Move a few temporarily-allowed autofill dependencies to a test-file-only section. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/api/infobars/DEPS ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # Autofill is being made into a Browser Component, so we have these 2 # Autofill is being made into a Browser Component, so we have these
3 # two basic rules followed by temporary exceptions. Please don't 3 # three basic rules followed by temporary exceptions. Please don't
4 # add to the list of exceptions! 4 # add to the list of exceptions!
5 "-chrome/browser", 5 "-chrome/browser",
6 "+chrome/browser/api", 6 "+chrome/browser/api",
7 "+chrome/browser/autofill", 7 "+chrome/browser/autofill",
8 8
9 # Permanently-allowed DEPS beyond the standard Browser
10 # Components-like DEPS above go here.
11 "+third_party/libphonenumber", # For phone number i18n.
12
9 # TODO(joi): Bring this list to zero. 13 # TODO(joi): Bring this list to zero.
10 # 14 #
11 # Do not add to the list of temporarily-allowed dependencies below, 15 # Do not add to the list of temporarily-allowed dependencies below,
12 # and please do not introduce more #includes of these files. 16 # and please do not introduce more #includes of these files.
13 "!chrome/browser/infobars/infobar_tab_helper.h", 17 "!chrome/browser/infobars/infobar_tab_helper.h",
14 "!chrome/browser/password_manager/encryptor.h",
15 "!chrome/browser/password_manager/password_manager.h", 18 "!chrome/browser/password_manager/password_manager.h",
16 "!chrome/browser/prefs/pref_change_registrar.h", 19 "!chrome/browser/prefs/pref_change_registrar.h",
17 "!chrome/browser/prefs/pref_member.h", 20 "!chrome/browser/prefs/pref_member.h",
18 "!chrome/browser/prefs/pref_service.h", 21 "!chrome/browser/prefs/pref_service.h",
19 "!chrome/browser/profiles/profile.h", 22 "!chrome/browser/profiles/profile.h",
20 "!chrome/browser/profiles/profile_dependency_manager.h", 23 "!chrome/browser/profiles/profile_dependency_manager.h",
21 "!chrome/browser/profiles/profile_keyed_service.h", 24 "!chrome/browser/profiles/profile_keyed_service.h",
22 "!chrome/browser/profiles/profile_keyed_service_factory.h", 25 "!chrome/browser/profiles/profile_keyed_service_factory.h",
23 "!chrome/browser/sync/profile_sync_service.h", 26 "!chrome/browser/sync/profile_sync_service.h",
24 "!chrome/browser/sync/profile_sync_service_factory.h", 27 "!chrome/browser/sync/profile_sync_service_factory.h",
25 "!chrome/browser/sync/profile_sync_service_observer.h", 28 "!chrome/browser/sync/profile_sync_service_observer.h",
26 "!chrome/browser/translate/translate_infobar_delegate.h",
27 "!chrome/browser/translate/translate_manager.h",
28 "!chrome/browser/ui/browser.h", 29 "!chrome/browser/ui/browser.h",
29 "!chrome/browser/ui/browser_finder.h", 30 "!chrome/browser/ui/browser_finder.h",
30 "!chrome/browser/ui/browser_tabstrip.h",
31 "!chrome/browser/ui/browser_window.h", 31 "!chrome/browser/ui/browser_window.h",
32 "!chrome/browser/ui/chrome_pages.h", 32 "!chrome/browser/ui/chrome_pages.h",
33 "!chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.h", 33 "!chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.h",
34 "!chrome/browser/ui/gtk/gtk_theme_service.h", 34 "!chrome/browser/ui/gtk/gtk_theme_service.h",
35 "!chrome/browser/ui/tab_contents/tab_contents.h", 35 "!chrome/browser/ui/tab_contents/tab_contents.h",
36 "!chrome/browser/ui/tab_contents/test_tab_contents.h",
37 "!chrome/browser/ui/webui/feedback_ui.h",
38 "!chrome/browser/webdata/autofill_entry.h", 36 "!chrome/browser/webdata/autofill_entry.h",
39 "!chrome/browser/webdata/web_data_service.h", 37 "!chrome/browser/webdata/web_data_service.h",
40 "!chrome/browser/webdata/web_data_service_factory.h", 38 "!chrome/browser/webdata/web_data_service_factory.h",
41 # Do not add to the list of temporarily-allowed dependencies above, 39 # Do not add to the list of temporarily-allowed dependencies above,
42 # and please do not introduce more #includes of these files. 40 # and please do not introduce more #includes of these files.
43 41
44 # TODO(akalin): Remove this dependency. 42 # TODO(akalin): Remove this dependency.
45 "+sync/util/data_encryption_win.h", 43 "!sync/util/data_encryption_win.h",
46 "+third_party/libphonenumber", # For phone number i18n.
47 ] 44 ]
45
46 specific_include_rules = {
47 # TODO(joi): Bring this list to zero.
48 #
49 # Do not add to the list of temporarily-allowed dependencies below,
50 # and please do not introduce more #includes of these files.
51 '.*_[a-z]*test\.cc': [
52 "!chrome/browser/password_manager/encryptor.h",
53 "!chrome/browser/translate/translate_infobar_delegate.h",
54 "!chrome/browser/translate/translate_manager.h",
55 "!chrome/browser/ui/browser_tabstrip.h",
56 "!chrome/browser/ui/tab_contents/test_tab_contents.h",
57 ]
58 }
OLDNEW
« no previous file with comments | « chrome/browser/api/infobars/DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698