Add moar logging for "Couldn't load plug-in" errors.

Add moar logging for "Couldn't load plug-in" errors.


BUG=141055
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151246

[Bernhard Bauer, 2012-08-10 09:58:53]

Please review.

[piman, 2012-08-10 17:06:15]

LGTM overall, but we will want to cleanup after the investigation (this may get
spammy).
Also, please not one of the failure modes that I suspect is going to be the most
common.

https://chromiumcodereview.appspot.com/10854092/diff/1/ipc/ipc_sync_channel.cc
File ipc/ipc_sync_channel.cc (right):

https://chromiumcodereview.appspot.com/10854092/diff/1/ipc/ipc_sync_channel.c...
ipc/ipc_sync_channel.cc:310: LOG(ERROR) << "Received error reply";
I'm afraid this is going to be spammy. There's quite a few places in Chrome
where we return "error" messages under certain legitimate conditions.
If we're going to land this, we should file a bug to remove it.

https://chromiumcodereview.appspot.com/10854092/diff/1/ipc/ipc_sync_channel.c...
ipc/ipc_sync_channel.cc:345: CancelPendingSends();
I think this is going to be one of the most common modes of failure for Send().
When we get a channel error, for example because the other side closed the
channel, we get here, cancel the Sends, so that they pop out with send_result
still false - that's not caught by your other logs.
You may want to add logging here.

[Bernhard Bauer, 2012-08-13 07:39:35]

https://chromiumcodereview.appspot.com/10854092/diff/1/ipc/ipc_sync_channel.cc
File ipc/ipc_sync_channel.cc (right):

https://chromiumcodereview.appspot.com/10854092/diff/1/ipc/ipc_sync_channel.c...
ipc/ipc_sync_channel.cc:310: LOG(ERROR) << "Received error reply";
On 2012/08/10 17:06:15, piman wrote:
> I'm afraid this is going to be spammy. There's quite a few places in Chrome
> where we return "error" messages under certain legitimate conditions.
> If we're going to land this, we should file a bug to remove it.

Added a TODO. FWIW, in my (casual) testing this didn't add much more noisiness
to the output that what is already present (we log all Javascript console
messages, for example).

https://chromiumcodereview.appspot.com/10854092/diff/1/ipc/ipc_sync_channel.c...
ipc/ipc_sync_channel.cc:345: CancelPendingSends();
On 2012/08/10 17:06:15, piman wrote:
> I think this is going to be one of the most common modes of failure for
Send().
> When we get a channel error, for example because the other side closed the
> channel, we get here, cancel the Sends, so that they pop out with send_result
> still false - that's not caught by your other logs.
> You may want to add logging here.

Good catch! Added logging.

[commit-bot: I haz the power, 2012-08-13 07:41:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/10854092/8001

[commit-bot: I haz the power, 2012-08-13 09:41:20]

Change committed as 151246