Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Unified Diff: content/common/indexed_db/indexed_db_dispatcher.cc

Issue 10854081: IndexedDB: Simplify cursor data callbacks. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/indexed_db/indexed_db_dispatcher.cc
diff --git a/content/common/indexed_db/indexed_db_dispatcher.cc b/content/common/indexed_db/indexed_db_dispatcher.cc
index 55a7bdb2f27d9c02609627932fcb659b7379315d..44521876167bf285d07f35db75a135843e6e7760 100644
--- a/content/common/indexed_db/indexed_db_dispatcher.cc
+++ b/content/common/indexed_db/indexed_db_dispatcher.cc
@@ -635,9 +635,6 @@ void IndexedDBDispatcher::OnSuccessOpenCursor(
RendererWebIDBCursorImpl* cursor = new RendererWebIDBCursorImpl(object_id);
cursors_[object_id] = cursor;
- // TODO(jsbell): Remove the next two calls after WK92278 rolls.
- cursor->SetKeyAndValue(key, primary_key, value);
- callbacks->onSuccess(cursor);
callbacks->onSuccess(cursor, key, primary_key, value);
pending_callbacks_.Remove(response_id);
@@ -654,15 +651,11 @@ void IndexedDBDispatcher::OnSuccessCursorContinue(
RendererWebIDBCursorImpl* cursor = cursors_[cursor_id];
DCHECK(cursor);
- // TODO(jsbell): Remove the next call after WK92278·rolls.
- cursor->SetKeyAndValue(key, primary_key, value);
WebIDBCallbacks* callbacks = pending_callbacks_.Lookup(response_id);
if (!callbacks)
return;
- // TODO(jsbell): Remove the ...WithContinuation call after WK92278 rolls.
- callbacks->onSuccessWithContinuation();
callbacks->onSuccess(key, primary_key, value);
pending_callbacks_.Remove(response_id);
« no previous file with comments | « content/browser/in_process_webkit/indexed_db_dispatcher_host.cc ('k') | content/common/indexed_db/proxy_webidbcursor_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698