Issue 10854072: gdata: Remove use of FindEntryByPathSync() fromMoveOnUIThread()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10854072: gdata: Remove use of FindEntryByPathSync() fromMoveOnUIThread() (Closed)

Created:
8 years, 4 months ago by satorux1

Modified:
8 years, 4 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Remove use of FindEntryByPathSync() from MoveOnUIThread() The number of calles of FindEntryByPathSync() is reduced from 15 to 13. BUG=137694, 126634, 139446 TEST=Moving a file to another directory and renaming in the same directory work as before from file manager Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150871

Patch Set 1 #

Patch Set 2 : update a comment #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -19 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View		3 chunks	+32 lines, -19 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_interface.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

achuithb

On 2012/08/09 17:53:09, satorux1 wrote: 10831212 is not a valid bug.

8 years, 4 months ago (2012-08-09 18:21:07 UTC) #2

lgtm

Expand Messages | Collapse Messages