Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 10854071: New OOBE design: minor content update (Closed)

Created:
8 years, 4 months ago by Nikita (slow)
Modified:
8 years, 4 months ago
Reviewers:
Ivan Korotkov
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

New OOBE design: minor content update BUG=141559 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151157

Patch Set 1 #

Patch Set 2 : it #

Patch Set 3 : . #

Patch Set 4 : fix #

Total comments: 2

Patch Set 5 : nit #

Patch Set 6 : merge #

Patch Set 7 : dot #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -16 lines) Patch
M chrome/browser/resources/chromeos/login/oobe.css View 1 2 3 4 5 6 7 9 chunks +33 lines, -13 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_network.html View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_update.html View 1 2 3 4 5 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nikita (slow)
8 years, 4 months ago (2012-08-10 20:26:41 UTC) #1
Ivan Korotkov
lgtm https://chromiumcodereview.appspot.com/10854071/diff/1007/chrome/browser/resources/chromeos/login/oobe.css File chrome/browser/resources/chromeos/login/oobe.css (right): https://chromiumcodereview.appspot.com/10854071/diff/1007/chrome/browser/resources/chromeos/login/oobe.css#newcode801 chrome/browser/resources/chromeos/login/oobe.css:801: html[oobe=old] #update #update-screen-curtain { Isn't it a DIV ...
8 years, 4 months ago (2012-08-10 20:32:52 UTC) #2
Nikita (slow)
https://chromiumcodereview.appspot.com/10854071/diff/1007/chrome/browser/resources/chromeos/login/oobe.css File chrome/browser/resources/chromeos/login/oobe.css (right): https://chromiumcodereview.appspot.com/10854071/diff/1007/chrome/browser/resources/chromeos/login/oobe.css#newcode801 chrome/browser/resources/chromeos/login/oobe.css:801: html[oobe=old] #update #update-screen-curtain { On 2012/08/10 20:32:52, Ivan Korotkov ...
8 years, 4 months ago (2012-08-10 20:47:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/10854071/10008
8 years, 4 months ago (2012-08-10 21:46:11 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-10 23:54:23 UTC) #5
Change committed as 151157

Powered by Google App Engine
This is Rietveld 408576698