Fix a bad inversion of logic (see OnCanThrottleRequest) and a bug

Fix a bad inversion of logic (see OnCanThrottleRequest) and a bug
related to how a flag was persisted.

BUG=141081, 141643
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150928

[Jói, 2012-08-09 16:46:51]

I introduced both of these embarrassing bugs in http://crrev.com/141000.  This
is the simple fix, for which I will be requesting a merge to Beta and Stable.  A
follow-up change will add tests to try to avoid the possibility of this
happening again.

I have gone carefully through manual tests to ensure that this time, the
behavior is correct; only requests originating from extensions are ever
throttled, and no requests at all are throttled when you pass the flag.  I'm
sure I ran through the tests as well for r141000, but I guess I got them wrong
somehow :(

Cheers,
Jói (henceforth known as Jói the Foolish)

[eroman, 2012-08-09 19:04:32]

LGTM.

I am also to blame since I must not have noticed during initial code review!

http://codereview.chromium.org/10854069/diff/1/chrome/browser/net/chrome_netw...
File chrome/browser/net/chrome_network_delegate.h (right):

http://codereview.chromium.org/10854069/diff/1/chrome/browser/net/chrome_netw...
chrome/browser/net/chrome_network_delegate.h:53: void NeverThrottleRequests();
Seems this should be a static method now

[commit-bot: I haz the power, 2012-08-09 21:27:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/10854069/8001

[Jói, 2012-08-09 21:27:40]

Thanks for the quick review.

http://codereview.chromium.org/10854069/diff/1/chrome/browser/net/chrome_netw...
File chrome/browser/net/chrome_network_delegate.h (right):

http://codereview.chromium.org/10854069/diff/1/chrome/browser/net/chrome_netw...
chrome/browser/net/chrome_network_delegate.h:53: void NeverThrottleRequests();
On 2012/08/09 19:04:32, eroman wrote:
> Seems this should be a static method now

Done, committing now.

[commit-bot: I haz the power, 2012-08-09 22:48:51]

Change committed as 150928