net/socket/client_socket_pool_base.h - Issue 10854063: Clean-up inline members of nested classes (net/)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_pool_base.h

Issue 10854063: Clean-up inline members of nested classes (net/) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressing comments Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/client_socket_pool_base.h

diff --git a/net/socket/client_socket_pool_base.h b/net/socket/client_socket_pool_base.h

index 834835aede682ea071a12ec35f424d88a81068a2..e35ab29fca11f767943d2ff2a676ac216e3921b4 100644

--- a/net/socket/client_socket_pool_base.h

+++ b/net/socket/client_socket_pool_base.h

@@ -442,9 +442,8 @@ class NET_EXPORT_PRIVATE ClientSocketPoolBaseHelper

typedef std::set<ConnectJob*> ConnectJobSet;

struct CallbackResultPair {

- CallbackResultPair() : result(OK) {}

- CallbackResultPair(const CompletionCallback& callback_in, int result_in)

- : callback(callback_in), result(result_in) {}

+ CallbackResultPair();

+ CallbackResultPair(const CompletionCallback& callback_in, int result_in);

~CallbackResultPair();

CompletionCallback callback;