Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2087)

Unified Diff: net/tools/flip_server/balsa_headers.h

Issue 10854063: Clean-up inline members of nested classes (net/) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add a NET_EXPOR_PRIVATE Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_session.cc ('k') | net/tools/flip_server/balsa_headers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/flip_server/balsa_headers.h
diff --git a/net/tools/flip_server/balsa_headers.h b/net/tools/flip_server/balsa_headers.h
index 981b5a7ec4fbe3fcea11b19f05a6c44f3577f432..1bd3100dac5c55918d1c4552dcb6821b8499b903 100644
--- a/net/tools/flip_server/balsa_headers.h
+++ b/net/tools/flip_server/balsa_headers.h
@@ -306,12 +306,10 @@ class BalsaHeaders {
typedef iterator_base self;
// default constructor.
- iterator_base() : headers_(NULL), idx_(0) { }
+ iterator_base();
// copy constructor.
- iterator_base(const iterator_base& it)
- : headers_(it.headers_),
- idx_(it.idx_) {}
+ iterator_base(const iterator_base& it);
reference operator*() const {
return Lookup(idx_);
@@ -353,9 +351,7 @@ class BalsaHeaders {
std::ostream& operator<<(std::ostream& os) const;
protected:
- iterator_base(const BalsaHeaders* headers, HeaderLines::size_type index) :
- headers_(headers),
- idx_(index) {}
+ iterator_base(const BalsaHeaders* headers, HeaderLines::size_type index);
void increment() {
const HeaderLines& header_lines = headers_->header_lines_;
@@ -536,6 +532,7 @@ class BalsaHeaders {
friend class BalsaHeaders;
public:
typedef const_header_lines_key_iterator self;
+ const_header_lines_key_iterator(const const_header_lines_key_iterator&);
self& operator++() {
do {
@@ -554,16 +551,11 @@ class BalsaHeaders {
private:
const_header_lines_key_iterator(const BalsaHeaders* headers,
HeaderLines::size_type index,
- const base::StringPiece& key)
- : iterator_base(headers, index),
- key_(key) {
- }
+ const base::StringPiece& key);
// Should only be used for creating an end iterator.
const_header_lines_key_iterator(const BalsaHeaders* headers,
- HeaderLines::size_type index)
- : iterator_base(headers, index) {
- }
+ HeaderLines::size_type index);
bool AtEnd() const {
return *this >= headers_->header_lines_end();
« no previous file with comments | « net/spdy/spdy_session.cc ('k') | net/tools/flip_server/balsa_headers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698