Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: net/socket_stream/socket_stream.h

Issue 10854063: Clean-up inline members of nested classes (net/) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add a NET_EXPOR_PRIVATE Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/tcp_client_socket_libevent.cc ('k') | net/socket_stream/socket_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket_stream/socket_stream.h
diff --git a/net/socket_stream/socket_stream.h b/net/socket_stream/socket_stream.h
index 2bc0ebee797b6d74dffdceadca5f4eb6d0542fd3..5220e4c3ca2da2d8ef6c29dbf1c01b6342859b3b 100644
--- a/net/socket_stream/socket_stream.h
+++ b/net/socket_stream/socket_stream.h
@@ -60,9 +60,7 @@ class NET_EXPORT SocketStream
class NET_EXPORT Delegate {
public:
virtual int OnStartOpenConnection(SocketStream* socket,
- const CompletionCallback& callback) {
- return OK;
- }
+ const CompletionCallback& callback);
// Called when socket stream has been connected. The socket stream accepts
// at most |max_pending_send_allowed| so that a client of the socket stream
@@ -86,19 +84,14 @@ class NET_EXPORT SocketStream
// The delegate should call RestartWithAuth() if credential for |auth_info|
// is found in password database, or call Close() to close the connection.
virtual void OnAuthRequired(SocketStream* socket,
- AuthChallengeInfo* auth_info) {
- // By default, no credential is available and close the connection.
- socket->Close();
- }
+ AuthChallengeInfo* auth_info);
// Called when using SSL and the server responds with a certificate with an
// error. The delegate should call CancelBecauseOfCertError() or
// ContinueDespiteCertError() to resume connection handling.
virtual void OnSSLCertificateError(SocketStream* socket,
const SSLInfo& ssl_info,
- bool fatal) {
- socket->CancelWithSSLError(ssl_info);
- }
+ bool fatal);
// Called when an error occured.
// This is only for error reporting to the delegate.
@@ -107,18 +100,14 @@ class NET_EXPORT SocketStream
// Called when reading cookies to allow the delegate to block access to the
// cookie.
- virtual bool CanGetCookies(SocketStream* socket, const GURL& url) {
- return true;
- }
+ virtual bool CanGetCookies(SocketStream* socket, const GURL& url);
// Called when a cookie is set to allow the delegate to block access to the
// cookie.
virtual bool CanSetCookie(SocketStream* request,
const GURL& url,
const std::string& cookie_line,
- CookieOptions* options) {
- return true;
- }
+ CookieOptions* options);
protected:
virtual ~Delegate() {}
@@ -211,7 +200,7 @@ class NET_EXPORT SocketStream
std::string headers_;
private:
- virtual ~RequestHeaders() { data_ = NULL; }
+ virtual ~RequestHeaders();
};
class ResponseHeaders : public IOBuffer {
« no previous file with comments | « net/socket/tcp_client_socket_libevent.cc ('k') | net/socket_stream/socket_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698