Clean-up inline members of nested classes (net/)

net/socket/tcp_client_socket_libevent.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_TCP_CLIENT_SOCKET_LIBEVENT_H_
 #define NET_SOCKET_TCP_CLIENT_SOCKET_LIBEVENT_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
@@ skipping 66 matching lines @@
  private:
   // State machine for connecting the socket.
   enum ConnectState {
     CONNECT_STATE_CONNECT,
     CONNECT_STATE_CONNECT_COMPLETE,
     CONNECT_STATE_NONE,
   };
 
   class ReadWatcher : public MessageLoopForIO::Watcher {
    public:
     explicit ReadWatcher(TCPClientSocketLibevent* socket) : socket_(socket) {}

[mmenke, 2012/08/09 15:13:35]

Sholdn't this also be de-inlined?

[hans, 2012/08/09 15:35:42]

The plugin didn't complain about it.

 
     // MessageLoopForIO::Watcher methods
 
-    virtual void OnFileCanReadWithoutBlocking(int /* fd */) OVERRIDE {
-      if (!socket_->read_callback_.is_null())
-        socket_->DidCompleteRead();
-    }
+    virtual void OnFileCanReadWithoutBlocking(int /* fd */) OVERRIDE;
 
     virtual void OnFileCanWriteWithoutBlocking(int /* fd */) OVERRIDE {}
 
    private:
     TCPClientSocketLibevent* const socket_;
 
     DISALLOW_COPY_AND_ASSIGN(ReadWatcher);
   };
 
   class WriteWatcher : public MessageLoopForIO::Watcher {
    public:
     explicit WriteWatcher(TCPClientSocketLibevent* socket) : socket_(socket) {}

[mmenke, 2012/08/09 15:13:35]

Sholdn't this also be de-inlined?

[hans, 2012/08/09 15:35:42]

The plugin didn't complain about it.

 
     // MessageLoopForIO::Watcher implementation.
     virtual void OnFileCanReadWithoutBlocking(int /* fd */) OVERRIDE {}
-    virtual void OnFileCanWriteWithoutBlocking(int /* fd */) OVERRIDE {
-      if (socket_->waiting_connect()) {
-        socket_->DidCompleteConnect();
-      } else if (!socket_->write_callback_.is_null()) {
-        socket_->DidCompleteWrite();
-      }
-    }
+    virtual void OnFileCanWriteWithoutBlocking(int /* fd */) OVERRIDE;
 
    private:
     TCPClientSocketLibevent* const socket_;
 
     DISALLOW_COPY_AND_ASSIGN(WriteWatcher);
   };
 
   // State machine used by Connect().
   int DoConnectLoop(int result);
   int DoConnect();
@@ skipping 81 matching lines @@
   base::TimeTicks connect_start_time_;
   base::TimeDelta connect_time_micros_;
   int64 num_bytes_read_;
 
   DISALLOW_COPY_AND_ASSIGN(TCPClientSocketLibevent);
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_TCP_CLIENT_SOCKET_LIBEVENT_H_