Clean-up inline members of nested classes (net/)

net/proxy/proxy_config_service_mac.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_PROXY_PROXY_CONFIG_SERVICE_MAC_H_
 #define NET_PROXY_PROXY_CONFIG_SERVICE_MAC_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
@@ skipping 28 matching lines @@
   virtual ConfigAvailability GetLatestProxyConfig(ProxyConfig* config) OVERRIDE;
 
  private:
   class Helper;
 
   // Forwarder just exists to keep the NetworkConfigWatcherMac API out of
   // ProxyConfigServiceMac's public API.
   class Forwarder : public NetworkConfigWatcherMac::Delegate {
    public:
     explicit Forwarder(ProxyConfigServiceMac* proxy_config_service)
         : proxy_config_service_(proxy_config_service) {}

[mmenke, 2012/08/09 15:13:35]

Shouldn't you de-inline this as well?  You did so with other initializer-only
constructors.

[hans, 2012/08/09 15:35:42]

Those constructors were considered more complex by the plugin. I can out-of-line
this for consistency if you'd like.

 
     // NetworkConfigWatcherMac::Delegate implementation:
     virtual void StartReachabilityNotifications() OVERRIDE {}
     virtual void SetDynamicStoreNotificationKeys(SCDynamicStoreRef store)
-        OVERRIDE {
-      proxy_config_service_->SetDynamicStoreNotificationKeys(store);
-    }
-    virtual void OnNetworkConfigChange(CFArrayRef changed_keys) OVERRIDE {
-      proxy_config_service_->OnNetworkConfigChange(changed_keys);
-    }
+        OVERRIDE;

[mmenke, 2012/08/09 15:13:35]

nit:  OVERRIDE is generally not placed on its own line, so this should be:

    virtual void SetDynamicStoreNotificationKeys(
        SCDynamicStoreRef store) OVERRIDE;

[hans, 2012/08/09 15:35:42]

Done.

+    virtual void OnNetworkConfigChange(CFArrayRef changed_keys) OVERRIDE;
 
    private:
     ProxyConfigServiceMac* const proxy_config_service_;
     DISALLOW_COPY_AND_ASSIGN(Forwarder);
   };
 
   // Methods directly called by the NetworkConfigWatcherMac::Delegate:
   void SetDynamicStoreNotificationKeys(SCDynamicStoreRef store);
   void OnNetworkConfigChange(CFArrayRef changed_keys);
 
@@ skipping 13 matching lines @@
 
   // The thread that we expect to be operated on.
   const scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(ProxyConfigServiceMac);
 };
 
 }  // namespace net
 
 #endif  // NET_PROXY_PROXY_CONFIG_SERVICE_MAC_H_