Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: net/http/http_proxy_client_socket_pool.cc

Issue 10854063: Clean-up inline members of nested classes (net/) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_proxy_client_socket_pool.h" 5 #include "net/http/http_proxy_client_socket_pool.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/time.h" 9 #include "base/time.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 return new HttpProxyConnectJob(group_name, 373 return new HttpProxyConnectJob(group_name,
374 request.params(), 374 request.params(),
375 ConnectionTimeout(), 375 ConnectionTimeout(),
376 transport_pool_, 376 transport_pool_,
377 ssl_pool_, 377 ssl_pool_,
378 host_resolver_, 378 host_resolver_,
379 delegate, 379 delegate,
380 net_log_); 380 net_log_);
381 } 381 }
382 382
383 base::TimeDelta
384 HttpProxyClientSocketPool::HttpProxyConnectJobFactory::
385 ConnectionTimeout() const {
mmenke 2012/08/09 15:13:35 nit: I think this may be a little more readable:
hans 2012/08/09 15:35:42 Done.
386 return timeout_;
387 }
388
383 HttpProxyClientSocketPool::HttpProxyClientSocketPool( 389 HttpProxyClientSocketPool::HttpProxyClientSocketPool(
384 int max_sockets, 390 int max_sockets,
385 int max_sockets_per_group, 391 int max_sockets_per_group,
386 ClientSocketPoolHistograms* histograms, 392 ClientSocketPoolHistograms* histograms,
387 HostResolver* host_resolver, 393 HostResolver* host_resolver,
388 TransportClientSocketPool* transport_pool, 394 TransportClientSocketPool* transport_pool,
389 SSLClientSocketPool* ssl_pool, 395 SSLClientSocketPool* ssl_pool,
390 NetLog* net_log) 396 NetLog* net_log)
391 : transport_pool_(transport_pool), 397 : transport_pool_(transport_pool),
392 ssl_pool_(ssl_pool), 398 ssl_pool_(ssl_pool),
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 return base_.histograms(); 517 return base_.histograms();
512 } 518 }
513 519
514 bool HttpProxyClientSocketPool::CloseOneIdleConnection() { 520 bool HttpProxyClientSocketPool::CloseOneIdleConnection() {
515 if (base_.CloseOneIdleSocket()) 521 if (base_.CloseOneIdleSocket())
516 return true; 522 return true;
517 return base_.CloseOneIdleConnectionInLayeredPool(); 523 return base_.CloseOneIdleConnectionInLayeredPool();
518 } 524 }
519 525
520 } // namespace net 526 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698