Clean-up inline members of nested classes (net/)

net/disk_cache/rankings.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See net/disk_cache/disk_cache.h for the public interface.
 
 #ifndef NET_DISK_CACHE_RANKINGS_H_
 #define NET_DISK_CACHE_RANKINGS_H_
 
 #include <list>
@@ skipping 46 matching lines @@
     RESERVED,     // Reserved for future use.
     DELETED,      // List of recently deleted or doomed entries.
     LAST_ELEMENT
   };
 
   // This class provides a specialized version of scoped_ptr, that calls
   // Rankings whenever a CacheRankingsBlock is deleted, to keep track of cache
   // iterators that may go stale.
   class ScopedRankingsBlock : public scoped_ptr<CacheRankingsBlock> {
    public:
-    ScopedRankingsBlock() : rankings_(NULL) {}
-    explicit ScopedRankingsBlock(Rankings* rankings) : rankings_(rankings) {}
-    ScopedRankingsBlock(Rankings* rankings, CacheRankingsBlock* node)
-        : scoped_ptr<CacheRankingsBlock>(node), rankings_(rankings) {}
+    ScopedRankingsBlock();
+    explicit ScopedRankingsBlock(Rankings* rankings);
+    ScopedRankingsBlock(Rankings* rankings, CacheRankingsBlock* node);
 
     ~ScopedRankingsBlock() {
       rankings_->FreeRankingsBlock(get());

[mmenke, 2012/08/09 15:13:35]

Shouldn't this also be de-inlined?

[hans, 2012/08/09 15:35:42]

The plugin wasn't complaining about it. I can out-of-line it for consitency if
you'd like.

     }
 
     void set_rankings(Rankings* rankings) {
       rankings_ = rankings;
     }
 
     // scoped_ptr::reset will delete the object.
     void reset(CacheRankingsBlock* p = NULL) {
       if (p != get())
         rankings_->FreeRankingsBlock(get());
@@ skipping 123 matching lines @@
   BackendImpl* backend_;
   LruData* control_data_;  // Data related to the LRU lists.
   IteratorList iterators_;
 
   DISALLOW_COPY_AND_ASSIGN(Rankings);
 };
 
 }  // namespace disk_cache
 
 #endif  // NET_DISK_CACHE_RANKINGS_H_